Skip to content

Conversation

@pau-hedgehog
Copy link
Contributor

No description provided.

@pau-hedgehog pau-hedgehog self-assigned this Nov 21, 2025
@pau-hedgehog pau-hedgehog requested a review from a team as a code owner November 21, 2025 11:01
@github-actions
Copy link

github-actions bot commented Nov 21, 2025

🚀 Deployed on https://preview-230--hedgehog-docs.netlify.app

@@ -0,0 +1,346 @@
# DHCP

The Fabric includes an integrated DHCP server that dinamically assigns IP addresses to hosts connected to VPC subnets. The DHCP server supports dynamic IP allocation, static leases, and various configuration options.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The Fabric includes an integrated DHCP server that dinamically assigns IP addresses to hosts connected to VPC subnets. The DHCP server supports dynamic IP allocation, static leases, and various configuration options.
The Fabric includes an integrated DHCP server that dynamically assigns IP addresses to hosts connected to VPC subnets. The DHCP server supports dynamic IP allocation, static leases, and various configuration options.

namespace: default
spec:
subnets:
default:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a comment or annotation to mention that this is the name of the subnet and can be changed as the user desires?

| `timeServers` | List of NTP server IP addresses | None |
| `interfaceMTU` | MTU size for the interface (doesn't affect switch interfaces) | 9036 |
| `pxeURL` | PXE boot server URL (TFTP only, no HTTP query strings) | None |
| `disableDefaultRoute` | If true, don't send default route to clients | false |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you put the option number we either are or aren't sending with this YAML config

!!! warning "VPC vs DHCPSubnet Configuration"
- Changes made to the VPC YAML will overwrite static leases configured directly in DHCPSubnet
- It's recommended to choose one method and stick with it to avoid configuration conflicts
- The VPC method is preferred for most use cases as it keeps configuration centralized
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on these warnings I am inferring that if a user makes a change in the DHCPSubnet configuration, the use won't be able to see those changes in the VPC object? If that is true, can we add that explicitly here? My concern comes from there being two people making changes and stepping on each others toes.

I like that you give guidance to use the VPC method.

Copy link
Contributor

@mrbojangles3 mrbojangles3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left comments inline

@Frostman Frostman requested a review from Copilot November 21, 2025 16:38
Copilot finished reviewing on behalf of Frostman November 21, 2025 16:40
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds comprehensive documentation for the integrated DHCP server feature in the Fabric user guide. The documentation covers configuration, management, and usage of DHCP services for VPC subnets.

  • Introduces complete DHCP server documentation with basic and advanced configuration examples
  • Documents static lease management via both VPC YAML and DHCPSubnet resources
  • Adds support for DHCP relay configuration with third-party DHCP servers

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.

File Description
docs/user-guide/dhcp.md New comprehensive documentation covering DHCP server configuration, options, static leases, and relay support
docs/user-guide/.pages Adds dhcp.md to the navigation menu in the user guide

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Signed-off-by: Pau Capdevila <pau@githedgehog.com>
Signed-off-by: Pau Capdevila <pau@githedgehog.com>
Signed-off-by: Pau Capdevila <pau@githedgehog.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants