Skip to content

t7519-status-fsmonitor: improve comments #404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

wilbaker
Copy link

This patch series is based on the 'wb/fsmonitor-bitmap-fix' branch and addresses feedback on the new test that was added there.

I've updated the comments for the new test to more accurately describe the scenario being tested.

Thanks,

William

Cc: williamtbakeremail@gmail.com, stolee@gmail.com, Johannes.Schindelin@gmx.de, jeffhost@microsoft.com

The comments for the staging/unstaging test did not accurately
describe the scenario being tested.  It is not essential that
the test files being staged/unstaged appear at the end of the
index.  All that is required is that the test files are not
flagged with CE_FSMONITOR_VALID and have a position in the
index greater than the number of entries in the index after
unstaging.

The comment for this test has been updated to be more
accurate with respect to the scenario that's being tested.

Signed-off-by: William Baker <William.Baker@microsoft.com>
@wilbaker
Copy link
Author

/submit

@gitgitgadget
Copy link

gitgitgadget bot commented Oct 16, 2019

Submitted as pull.404.git.1571254547.gitgitgadget@gmail.com

WARNING: wilbaker has no public email address set on GitHub

@@ -354,9 +354,11 @@ test_expect_success 'discard_index() also discards fsmonitor info' '
test_cmp expect actual
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On the Git mailing list, William Baker wrote (reply to this):

On 10/16/19 12:35 PM, William Baker via GitGitGadget wrote:
> From: William Baker <William.Baker@microsoft.com>
> 
> The comments for the staging/unstaging test did not accurately
> describe the scenario being tested.  It is not essential that
> the test files being staged/unstaged appear at the end of the
> index.  All that is required is that the test files are not
> flagged with CE_FSMONITOR_VALID and have a position in the
> index greater than the number of entries in the index after
> unstaging.
> 
> The comment for this test has been updated to be more
> accurate with respect to the scenario that's being tested.
> 
> Signed-off-by: William Baker <William.Baker@microsoft.com>
> ---
>  t/t7519-status-fsmonitor.sh | 8 +++++---
>  1 file changed, 5 insertions(+), 3 deletions(-)
> 
> diff --git a/t/t7519-status-fsmonitor.sh b/t/t7519-status-fsmonitor.sh
> index d8df990972..997d5fb349 100755
> --- a/t/t7519-status-fsmonitor.sh
> +++ b/t/t7519-status-fsmonitor.sh
> @@ -354,9 +354,11 @@ test_expect_success 'discard_index() also discards fsmonitor info' '
>  	test_cmp expect actual
>  '
>  
> -# Test staging/unstaging files that appear at the end of the index.  Test
> -# file names begin with 'z' so that they are sorted to the end of the index.
> -test_expect_success 'status succeeds after staging/unstaging ' '
> +# Test unstaging entries that:
> +#  - Are not flagged with CE_FSMONITOR_VALID
> +#  - Have a position in the index >= the number of entries present in the index
> +#    after unstaging.
> +test_expect_success 'status succeeds after staging/unstaging' '
>  	test_create_repo fsmonitor-stage-unstage &&
>  	(
>  		cd fsmonitor-stage-unstage &&
> 

Gentle ping on this patch.  It's just a small update to the comments
for an fsmonitor related test based on feedback I received in the
segfault fix patch series [1].

Thanks,
William

[1] https://public-inbox.org/git/3d3b290c-bc15-4bd5-e0c0-1377c9ec3ff9@gmail.com/

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On the Git mailing list, Junio C Hamano wrote (reply to this):

William Baker <williamtbakeremail@gmail.com> writes:

> Gentle ping on this patch.  It's just a small update to the comments
> for an fsmonitor related test based on feedback I received in the
> segfault fix patch series [1].

Thanks for a reminder.  Queued.

@gitgitgadget
Copy link

gitgitgadget bot commented Oct 30, 2019

This branch is now known as wb/fsmonitor-bitmap-fix.

@gitgitgadget
Copy link

gitgitgadget bot commented Oct 30, 2019

This patch series was integrated into pu via git@d2b76ab.

@gitgitgadget gitgitgadget bot added the pu label Oct 30, 2019
@gitgitgadget
Copy link

gitgitgadget bot commented Oct 30, 2019

This patch series was integrated into pu via git@8dc28ee.

@gitgitgadget
Copy link

gitgitgadget bot commented Oct 30, 2019

This patch series was integrated into next via git@8dc28ee.

@gitgitgadget
Copy link

gitgitgadget bot commented Oct 30, 2019

This patch series was integrated into master via git@8dc28ee.

@gitgitgadget
Copy link

gitgitgadget bot commented Oct 30, 2019

Closed via 8dc28ee.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants