Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document --stdin (and other options in setup_revisions) #243

Open
Denton-L opened this issue May 31, 2019 · 4 comments
Open

Document --stdin (and other options in setup_revisions) #243

Denton-L opened this issue May 31, 2019 · 4 comments

Comments

@Denton-L
Copy link
Member

Currently, Git accepts --stdin for the log family of commands. Well really, anything that calls setup_revisions from revisions.c and passes in its argv will implicitly have the --stdin option.

We should explicitly document this (and other) options.

@johnlinp
Copy link

What are the "other options"? Can you please elaborate?

@dscho
Copy link
Member

dscho commented Jun 24, 2019

What are the "other options"?

I think those are all of the options that are parsed in revision.c, in particular in handle_revision_opt().

The idea being that an interested contributor who wants to pick this up would analyze carefully which options are still undocumented (and where).

@johnlinp
Copy link

johnlinp commented Aug 2, 2019

I found that the file rev-list-options.txt contains the options that are parsed in revision.c, including --stdin. Currently it only appears in git-log.txt and git-rev-list.txt.

Is it a good idea to also put it into the git commands that support those options? Like git-revert.txt, git-show.txt, etc?

@Denton-L
Copy link
Member Author

I don't know the other builtin commands well enough to be able to tell if there would be any negative implications resulting in this change but if you're interested, I think it would be good to submit the patch and see what the mailing list thinks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants