#51 - Include process names in message before installing package.

gitextensions · Dec 14, 2020 · beabf5e · beabf5e
1 parent c5d7ab9
commit beabf5e
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 2 deletions.
diff --git a/src/PackageManager.UI/Services/ProcessService.ProcessKillContext.cs b/src/PackageManager.UI/Services/ProcessService.ProcessKillContext.cs
@@ -18,9 +18,14 @@ internal class ProcessKillContext
             public ProcessKillContext(IReadOnlyCollection<string> names)
             {
                 Ensure.NotNull(names, "names");
+                ProcessNames = names;
                 targets = names.SelectMany(name => Process.GetProcessesByName(name)).ToList();
             }
 
+            public IReadOnlyCollection<string> ProcessNames { get; }
+
+            public int ProcessCount { get => targets.Count; }
+
             public bool IsExecutable => targets.Count > 0;
 
             public void Execute()

diff --git a/src/PackageManager.UI/Views/MainWindow.xaml.cs b/src/PackageManager.UI/Views/MainWindow.xaml.cs
@@ -51,10 +51,13 @@ private Task<bool> OnBeforeChange()
             var context = processes.PrepareContextForProcessesKillBeforeChange();
             if (context.IsExecutable)
             {
+                var processNames = string.Join(" and ", context.ProcessNames);
+                if (context.ProcessCount > 1 || context.ProcessNames.Count > 1)
+                    processNames = $"all instances of {processNames}";
+
                 bool result = navigator.Confirm(
                     "Plugin Manager",
-                    "Plugin Manager is going to write to files that are holded by other executables. " + Environment.NewLine +
-                    "Do you want to kill all instances of these applications?"
+                    $"Plugin Manager will be writing to files that are currently in use.\r\n\r\nDo you want to stop {processNames}?"
                 );
 
                 if (result)