Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Where does the official purl test suite come from? #11

Closed
sjn opened this issue Feb 12, 2024 · 1 comment
Closed

Where does the official purl test suite come from? #11

sjn opened this issue Feb 12, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@sjn
Copy link

sjn commented Feb 12, 2024

Hei!

t/99-official-purl-test-suite.t is great to have, but needs a link to where the original data is from, so it's possible to keep it in sync as the original gets updated.

Also, with the upcoming versioning support, and Philippe's ambitions of formalizing the standard, knowing of - and using - authoritative test data is extra useful.

Maybe add a link, at minimum, and consider adding some way of keeping test data in sync with upstream?

@sjn sjn changed the title Where is the purl test suite? Where does the official purl test suite come from? Feb 12, 2024
@giterlizzi
Copy link
Owner

A great idea.

I modified t/99-official-purl-test-suite.t to read the original JSON file instead of having it embedded (in __DATA__), so as not to modify the file when Philippe adds or modifies tests.

I also added a shell script for downloading tests from the "purl" spec repository (https://raw.githubusercontent.com/package-url/purl-spec/master/test-suite-data.json), to make it easier to update the file offline or from CI/CD.

@giterlizzi giterlizzi added the enhancement New feature or request label Feb 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants