Skip to content

Only display keyboard shortcuts in V3 (#8153) #8377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 3, 2025

Conversation

Byron
Copy link
Collaborator

@Byron Byron commented May 3, 2025

Fixes #8153.

Caveats

  • The menu is only built at startup, and not updated afterwards. Hence dynamic switching between V2 and V3 leaves the menu in a stale state, either showing the keyboard shortcuts menu item where it should not, or not showing it where it should.
    That's deemed acceptable in the transition period.

In V2 it's not showing up, probably the implementation depends on V3
facilities. Fair enough.
Copy link

vercel bot commented May 3, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
gitbutler-components ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 3, 2025 5:59am

Copy link

vercel bot commented May 3, 2025

@Byron is attempting to deploy a commit to the GitButler Team on Vercel.

A member of the Team first needs to authorize it.

@Byron Byron marked this pull request as ready for review May 3, 2025 05:58
@Byron Byron enabled auto-merge May 3, 2025 05:58
@github-actions github-actions bot added the rust Pull requests that update Rust code label May 3, 2025
@Byron Byron merged commit 4ec4902 into gitbutlerapp:master May 3, 2025
19 of 20 checks passed
@Byron Byron deleted the keyboard-shortcuts branch May 3, 2025 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rust Pull requests that update Rust code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The "Keyboard shortcuts" option doesn't work
1 participant