Implementing a bad agent #8368
Closed
Implementing a bad agent #8368
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
github-actions
bot
added
rust
Byron
reviewed
May 2, 2025
| path: &str, | ||
| ) -> Result<Vec<String>, Error> { | ||
| let project = projects.get(project_id)?; | ||
| let files = std::fs::read_dir(project.path.join(path)).map_err(|err| anyhow::anyhow!(err))?; |
There was a problem hiding this comment.
I don't know anything about the feature itself, but I think it will be a worthwhile measure to first check if path is relative. Otherwise, absolute paths, when joined, will fully replace the project path, allowing 'breakouts'. The same would be true for agent_read_file.
There was a problem hiding this comment.
This is nothing more than just a demo and something I wanted to play around with.
We would indeed want to much more seriously consider the security before this gets anywhere near to master
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
⧓ Review in Butler Review
#1oCs8JHfkImplementing a bad agent
1 commit series (version 1)
Please leave review feedback in the Butler Review