feat(ui): apply text styles from settings to MessageEditor #8360
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@matthewevans is attempting to deploy a commit to the GitButler Team on Vercel. A member of the Team first needs to authorize it. |
|
Thanks @matthewevans! I was checking the PR and noticed that when I change the font in the input, only the font in the hunk header reflects the change — there’s no effect on anything else:
Also, there are no changes in the editor itself: 
Does it work as expected on your end? |
|
@PavelLaptev Oh nice catch. The settings dialog preview has apparently not worked... ever? I've added the relevant prop so it's applied now
|
|
Thanks! Works now :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧢 Changes
MessageEditor.sveltedown to the CSS layer using CSS custom properties (--code-block-font,--code-block-tab-size,--code-block-ligatures).standard-theme.cssto consume these new custom properties for code blocks (.StandardTheme__code), inline code (.StandardTheme__textCode), and the plain text container (.lexical-container.plain-text). Sensible defaults are provided in case the properties are not set.☕️ Reasoning
To apply a consistent visual representation of text styling across components.