feat(clipboard): move the toast-handling into writeClipboard function #7551
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@H1ghBre4k3r is attempting to deploy a commit to the GitButler Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
Author
|
@estib-vega I guess, you're the right one to review this (since you already reviewed the ButlerReview). :D |
estib-vega
approved these changes
Mar 9, 2025
Contributor
|
Let’s merge it :) |
PavelLaptev
pushed a commit
that referenced
this pull request
Mar 11, 2025
…eClipboard feat(clipboard): move the toast-handling into writeClipboard function
PavelLaptev
added a commit
that referenced
this pull request
Mar 11, 2025
* Merge pull request #7552 from gitbutlerapp/e-branch-134 Profile settings: Receive reply notification emails * Merge pull request #7553 from gitbutlerapp/e-branch-135 unclog toilet mode * Merge pull request #7555 from vidluther/master Use Claude Sonnet 3.7 and Node 22.14.0 * Merge pull request #7557 from gitbutlerapp/e-branch-136 more toilet mode fixes * Merge pull request #7551 from H1ghBre4k3r/move-error-handling-to-writeClipboard feat(clipboard): move the toast-handling into writeClipboard function * Remove inner div from scrollable containers - not strictly needed - enables `sticky` items in the scroll view * Merge pull request #7562 from gitbutlerapp/sc-server-features-login if user is not logged in, show login prompt * Fix for push button being visible all the time * Merge pull request #7563 from gitbutlerapp/popup-pirate Fix the project popup * nest generic classes, don't display stack size if null * add dividers between files * remove scroll animation (it was buggy) * sticky file headers * Merge branch 'master' into ui-fixes-15 * fix diff selection z-index * add diff selection buttons tooltips * return `opacity` on hover * update header height when it's changing --------- Co-authored-by: Esteban Vega <35891811+estib-vega@users.noreply.github.com> Co-authored-by: Mattias Granlund <mtsgrd@gmail.com> Co-authored-by: Scott Chacon <schacon@gmail.com> Co-authored-by: Caleb Owens <hello@calebowens.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧢 Changes
Move the toast handling (and, therefore, the error handling as well) of copying text to the clipboard into the
writeClipboardfunction.☕️ Reasoning
Previously, we managed the error handling (i.e., the display of a toast) individually for each call to
writeClipboard. To unify this, the handling is moved into the function.🎫 Affected issues
Fixes: #7490