Use user profile image instead of gravatar when available #5545
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@GordonBeeming is attempting to deploy a commit to the GitButler Team on Vercel. A member of the Team first needs to authorize it. |
GordonBeeming
changed the title
estib-vega
requested changes
Nov 14, 2024
apps/desktop/src/lib/navigation/BranchListingSidebarEntry.svelte
Outdated
Show resolved
Hide resolved
Refactor the author image URL logic in multiple components to use derived stores for better reactivity and cleaner code. This change eliminates redundant code and ensures that the author image URL updates automatically when the user or commit data changes.
GordonBeeming
force-pushed
the
user-profile-images
branch
from
0442f31 to
dad9303
Compare
|
@estib-vega updated, thanks for the help, I learnt new things 💪 |
estib-vega
approved these changes
Nov 15, 2024
|
Merging this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☕️ Reasoning
Users wanted to see their GitButler profile image instead of the gravatar one when they've suppled one
🧢 Changes
Updated locations where gravatarUrl were referenced for various git artifacts to check the users email, and if it's a match, then use the users profile
🎫 Affected issues
Fixes: #2589
NOTE: I've never worked with this tech stack, but am trying to learn... and really want to contribute to GitButler, so starting small.
If I've completely missed the mark on how to implement this change, please let me know and I'll do some more learning 😅