💚 Feature Request - Elevate Signed commits to the global/profile level and allow override at a project level

[GordonBeeming]

Currently, the Sign commits flag is at a project level

and it would be great to set this once at the profile level and allow override at a project level when required

[Byron]

Thanks a lot for sharing!

Just a moment ago I was thinking the same - typically those who want to sign their commits want to sign by default, but might want to turn off signing for some repositories.

But in fact, what I really think is that I'd expect it to just respect the Git configuration - using that it should be able to know what to do.

Somehow I have a feeling that this feature is a remnant of how application-made SSH keys were previously used, even though these are long gone.

CC @PavelLaptev and @krlvi - maybe a chance for simplification?

[Caleb-T-Owens]

We should default to whatever git is set at, and always use that unless otherwise specified at some point

[schacon]

That's strange, I thought we did look at / set the config settings through git.

[Byron]

When gitbutler.signCommits is unset, the UI shows it as disabled, and this is what the backend implements as well.

gitbutler/crates/but-rebase/src/commit.rs

Line 44 in 329322b

if repo.git_settings()?.gitbutler_sign_commits.unwrap_or(false) {

The UI should be able to detect if that configuration is set, and if not indicate that Git settings will be followed - the backend could then implement it accordingly. This would make gitbutler.signCommits some sort of override.

If #8238 makes commit-signing work for most out of the box, the setting can certainly also be made less prominent.