Improve typescript declaration files #409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry for the ignorance, but can we get some instructions on how/when to use these files? |
|
Well they're for TypeScript, and once you're using TS you don't have to do anything. |
gitbrent
approved these changes
Oct 12, 2018
gitbrent
added a commit
that referenced
this pull request
Oct 12, 2018
|
Thanks @michaelbeaumont ! You did a terrific job of upgrading that amateur defs I had in there... :-) |
ericrockey
pushed a commit
to WeTransfer/PptxGenJS
that referenced
this pull request
Mar 24, 2020
Improve typescript declaration files
ericrockey
pushed a commit
to WeTransfer/PptxGenJS
that referenced
this pull request
Mar 24, 2020
ericrockey
pushed a commit
to WeTransfer/PptxGenJS
that referenced
this pull request
Mar 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! We're using PptxGenJs in a typescript project and made a couple changes to the declaration files.