You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We are using reverse proxy. Gitblit is running only HTTP on port 29080 and apache does reverse proxy to HTTPS 4000.
It is caused by regression in pull request #1086, the solution of #1083.
It is because the port number is doubled. In the path, there is hardcoded check for 80 and 443, but there is no check if host already contains the port number.
With web.canonicalUrl = https://ourhost:4000 graph image is generated as
Yes, you're right - I didn't test with non-standart "outside" ports.
What solution do you propose? Extend the mentioned "if" to also check if "host" contains ":"?
Would you like to provide a fix / pull request?
We are using reverse proxy. Gitblit is running only HTTP on port 29080 and apache does reverse proxy to HTTPS 4000.
It is caused by regression in pull request #1086, the solution of #1083.
It is because the port number is doubled. In the path, there is hardcoded check for 80 and 443, but there is no check if host already contains the port number.
With
web.canonicalUrl = https://ourhost:4000
graph image is generated asweb.canonicalUrl
should contain nonstandard port.Setting just
web.canonicalUrl = https://ourhost
also does not work.The text was updated successfully, but these errors were encountered: