Skip to content

HttpUtils getGitblitURL does not support nonstandard ports #1114

Closed
@j123b567

Description

@j123b567

We are using reverse proxy. Gitblit is running only HTTP on port 29080 and apache does reverse proxy to HTTPS 4000.

It is caused by regression in pull request #1086, the solution of #1083.

It is because the port number is doubled. In the path, there is hardcoded check for 80 and 443, but there is no check if host already contains the port number.

With web.canonicalUrl = https://ourhost:4000 graph image is generated as

<img src="https://ourhost:4000:4000/graph/?r=........"></img>

web.canonicalUrl should contain nonstandard port.
Setting just web.canonicalUrl = https://ourhost also does not work.

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions