This repository was archived by the owner on Sep 26, 2021. It is now read-only.
Adding the ability to post process the screenshot. For example, one may ... #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ay want to resize (useful for iPad screen shots).
|
I'm not 100% sure how to show it, but I added the ability to scale the output screenshot, by using the last parameter in: UIGraphicsBeginImageContextWithOptions(imageRect.size, NO, [scale floatValue]) and then exposing another variable within the javascript side of the plugin. Works like a dream. I am pushing up the screenshots, and they were just unnecessarily too large for my purposes, and causing issues on some older devices, still running iOS 7+, as I know that call is only available on iOS4+. If anyone knows of a negative aspect of doing this, I'd love to mitigate that now. Only posting on this pull request since it's related, and could be a more straightforward approach to adding scale functionality. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...want to resize (useful for iPad screen shots).