Skip to content

Add display_name to users table and propagate sender info through all handlers#2311

Merged
hiroshinishio merged 2 commits intomainfrom
wes
Feb 23, 2026
Merged

Add display_name to users table and propagate sender info through all handlers#2311
hiroshinishio merged 2 commits intomainfrom
wes

Conversation

@hiroshinishio
Copy link
Collaborator

Summary

  • Rename get_user_public_email to get_user_public_info, returning a UserPublicInfo dataclass with both email and display_name
  • Add display_name (required, no default) to upsert_user and create_user_request
  • Add sender_display_name to BaseArgs and populate it from get_user_public_info in all three handlers (new_pr_handler, check_suite_handler, review_run_handler)
  • Fix check_suite_handler and review_run_handler to call get_user_public_info for real email/display_name instead of hardcoding fake noreply emails and empty strings
  • Title-case display names that are all lowercase or all uppercase (e.g. "wes nishio" -> "Wes Nishio", "HIROSHI" -> "Hiroshi")
  • Type user_data as dict[str, str | None] to fix Any type propagation from response.json()
  • Cross-ref comments between website and gitauto repos for the shared title-casing logic

…ough all handlers

- Rename get_user_public_email to get_user_public_info, return UserPublicInfo dataclass with email and display_name
- Add display_name (required) to upsert_user and create_user_request
- Add sender_display_name to BaseArgs, populate from get_user_public_info in all handlers
- Title-case display names that are all lowercase or all uppercase
- Fix check_suite_handler and review_run_handler to call get_user_public_info instead of hardcoding fake emails
- Type user_data as dict[str, str | None] to fix Any propagation
@hiroshinishio hiroshinishio self-assigned this Feb 23, 2026
@hiroshinishio hiroshinishio merged commit 7c975c2 into main Feb 23, 2026
1 check passed
@hiroshinishio hiroshinishio deleted the wes branch February 23, 2026 06:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant