Fix ESLint v8 crash and fatal error handling in verify_task_is_complete#2265
Merged
hiroshinishio merged 1 commit intomainfrom Feb 18, 2026
Merged
Fix ESLint v8 crash and fatal error handling in verify_task_is_complete#2265hiroshinishio merged 1 commit intomainfrom
hiroshinishio merged 1 commit intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
package.jsonand only use--no-warn-ignoredflag for v9+. Previously this flag crashed ESLint v8 repos with exit code 2, trapping the agent in an infinite verify loop until Lambda timeout (900s).get_dependency_major_version: Reusable utility to read a dependency's major version from package.json (checks devDependencies then dependencies, strips semver prefixes).Test plan
--no-warn-ignoredtests)get_dependency_major_versiontests pass (v8, v9, semver prefixes, missing package, invalid JSON)Social Media Post (GitAuto)
Found a bug that burned 900 seconds of Lambda time per PR on ESLint v8 repos. The --no-warn-ignored flag (v9 only) crashed ESLint v8, the agent saw "tests failed," retried, crashed again, looped until timeout. Fix: read the eslint version from package.json and skip the flag for v8.
Social Media Post (Wes)
A customer PR timed out at 900s. CloudWatch logs showed the agent running ESLint, crashing, retrying, crashing - four times in a row. We were passing --no-warn-ignored to ESLint 8, which doesn't support it. One version check in package.json broke the loop.