Code Review Bench PR #25696 - Align zh translations with China mainland terminology#9
Conversation
Code Review
|
| Auto-apply | Compact |
|
|
Was this helpful? React with 👍 / 👎 | Gitar
| "{amount} off forever.": "永久减免{amount}", | ||
| "{discount}% discount": "{discount}% 折扣", | ||
| "{memberEmail} will no longer receive {newsletterName} newsletter.": "{memberEmail}将不会再收到{newsletterName}的新闻信。", | ||
| "{memberEmail} will no longer receive {newsletterName} newsletter.": "{memberEmail}将不会再收到新闻信。", |
There was a problem hiding this comment.
⚠️ Bug: {newsletterName} variable dropped from Chinese translation
The translation for "{memberEmail} will no longer receive {newsletterName} newsletter." was changed from:
"{memberEmail}将不会再收到{newsletterName}的新闻信。"
to:
"{memberEmail}将不会再收到新闻信。"
The {newsletterName} template variable was removed from the translated value. When this string is rendered, the newsletter name will be omitted from the Chinese message, so users won't know which specific newsletter they unsubscribed from. This loses important contextual information, especially when a site has multiple newsletters.
Suggested fix: Keep the variable in the translation:
"{memberEmail}将不会再收到{newsletterName}新闻信。"
Was this helpful? React with 👍 / 👎
| "{memberEmail} will no longer receive {newsletterName} newsletter.": "{memberEmail}将不会再收到新闻信。", | |
| "{memberEmail} will no longer receive {newsletterName} newsletter.": "{memberEmail}将不会再收到{newsletterName}新闻信。", |
- Apply suggested fix
There was a problem hiding this comment.
Configure merge blocking · Maintainers can dismiss this review. Gitar never approves changes.
Benchmark PR for Gitar evaluation
Original PR: agentic-review-benchmarks#8
Updates Chinese translations to use China mainland terminology conventions.
Summary by Gitar
ghost.jsonandportal.jsonwith China mainland conventions: "留言" → "评论" (comment), "会籍" → "订阅" (subscription), "称呼" → "名字"/"名称" (name)ghost/i18n/locales/zh/comments.json(74 lines deleted)This will update automatically on new commits.