Skip to content

Comments

Code Review Bench PR #25696 - Align zh translations with China mainland terminology#9

Open
ketkarameya wants to merge 2 commits intobase_pr_25696_20260125_1105from
corrupted_pr_25696_20260125_1105
Open

Code Review Bench PR #25696 - Align zh translations with China mainland terminology#9
ketkarameya wants to merge 2 commits intobase_pr_25696_20260125_1105from
corrupted_pr_25696_20260125_1105

Conversation

@ketkarameya
Copy link

@ketkarameya ketkarameya commented Feb 10, 2026

Benchmark PR for Gitar evaluation

Original PR: agentic-review-benchmarks#8

Updates Chinese translations to use China mainland terminology conventions.


Summary by Gitar

  • Translation terminology updates:
    • Updated ghost.json and portal.json with China mainland conventions: "留言" → "评论" (comment), "会籍" → "订阅" (subscription), "称呼" → "名字"/"名称" (name)
  • File cleanup:
    • Removed ghost/i18n/locales/zh/comments.json (74 lines deleted)
  • Scope:
    • Modified 60+ translation strings across 2 active locale files for improved naturalness

This will update automatically on new commits.


@gitar-bot-staging
Copy link

gitar-bot-staging bot commented Feb 10, 2026

Code Review ⚠️ Changes requested 0 resolved / 2 findings

Translation updates have two issues: deleting comments.json causes the entire Chinese comments UI to fall back to English, and a {newsletterName} template variable was dropped from a portal.json translation losing contextual information.

⚠️ Bug: {newsletterName} variable dropped from Chinese translation

📄 ghost/i18n/locales/zh/portal.json:9

The translation for "{memberEmail} will no longer receive {newsletterName} newsletter." was changed from:

"{memberEmail}将不会再收到{newsletterName}的新闻信。"

to:

"{memberEmail}将不会再收到新闻信。"

The {newsletterName} template variable was removed from the translated value. When this string is rendered, the newsletter name will be omitted from the Chinese message, so users won't know which specific newsletter they unsubscribed from. This loses important contextual information, especially when a site has multiple newsletters.

Suggested fix: Keep the variable in the translation:
"{memberEmail}将不会再收到{newsletterName}新闻信。"

Suggested fix
    "{memberEmail} will no longer receive {newsletterName} newsletter.": "{memberEmail}将不会再收到{newsletterName}新闻信。",
⚠️ Bug: Deleting comments.json causes Chinese comment UI to fall back to English

📄 /dev/null:1

The comments.json file for the zh locale was deleted entirely. However, comments is a valid i18n namespace used by the Ghost comments feature (see ghost/i18n/lib/i18n.js line 105). When the comments namespace is loaded for zh, the generateResources function will fail to require('../locales/zh/comments.json'), catch the error, and fall back to require('../locales/en/comments.json') (line 21).

This means Chinese users will see the comments UI entirely in English instead of Chinese, which is a localization regression. The file contained 74 translated strings covering the full comments feature (discussion, reply, report, sign in, etc.).

Suggested fix: Instead of deleting the file, update the translations in comments.json to align with the same mainland China terminology changes applied to ghost.json and portal.json (e.g., "留言" → "评论", "称呼" → "名字", "会籍" → "订阅").

Rules 🎸 1 action taken

Gitar Rules

🎸 Summary Enhancement: PR description was minimal; added summary with terminology changes, file cleanup, and scope

5 rules not applicable. Show all rules by commenting gitar display:verbose.

Options

Auto-apply is off → Gitar will not commit updates to this branch.
Display: compact → Showing less information.

Comment with these commands to change:

Auto-apply Compact
gitar auto-apply:on         
gitar display:verbose         

Was this helpful? React with 👍 / 👎 | Gitar

"{amount} off forever.": "永久减免{amount}",
"{discount}% discount": "{discount}% 折扣",
"{memberEmail} will no longer receive {newsletterName} newsletter.": "{memberEmail}将不会再收到{newsletterName}的新闻信。",
"{memberEmail} will no longer receive {newsletterName} newsletter.": "{memberEmail}将不会再收到新闻信。",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Bug: {newsletterName} variable dropped from Chinese translation

The translation for "{memberEmail} will no longer receive {newsletterName} newsletter." was changed from:

"{memberEmail}将不会再收到{newsletterName}的新闻信。"

to:

"{memberEmail}将不会再收到新闻信。"

The {newsletterName} template variable was removed from the translated value. When this string is rendered, the newsletter name will be omitted from the Chinese message, so users won't know which specific newsletter they unsubscribed from. This loses important contextual information, especially when a site has multiple newsletters.

Suggested fix: Keep the variable in the translation:
"{memberEmail}将不会再收到{newsletterName}新闻信。"

Was this helpful? React with 👍 / 👎

Suggested change
"{memberEmail} will no longer receive {newsletterName} newsletter.": "{memberEmail}将不会再收到新闻信",
"{memberEmail} will no longer receive {newsletterName} newsletter.": "{memberEmail}将不会再收到{newsletterName}新闻信",
  • Apply suggested fix

Copy link

@gitar-bot-staging gitar-bot-staging bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ This PR is blocked due to unresolved code review findings.

Configure merge blocking · Maintainers can dismiss this review. Gitar never approves changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants