Code Review Bench PR #25813 - Renamed files to kebab-case - core - services - part 2#8
Conversation
![gitar-bot-staging[bot]](https://avatars.githubusercontent.com/in/812680?s=60&v=4){kind=small}
| const EmailEventProcessor = require('../email-service/EmailEventProcessor'); | ||
| const MailgunProvider = require('./EmailAnalyticsProviderMailgun'); | ||
| const EmailAnalyticsService = require('./email-analytics-service'); | ||
| const EmailEventStorage = require('../email-service/email-event-storage'); |
There was a problem hiding this comment.
🚨 Bug: Broken requires: email-event-storage/processor files not renamed
In email-analytics-service-wrapper.js, the require paths were updated to kebab-case (../email-service/email-event-storage and ../email-service/email-event-processor), but the actual files in the email-service/ directory were not renamed — they are still EmailEventStorage.js and EmailEventProcessor.js. This will cause a runtime MODULE_NOT_FOUND error when the email analytics service initializes, breaking email analytics functionality entirely.
On case-insensitive filesystems (macOS) this might not surface during local development, but it will fail on case-sensitive filesystems (Linux, CI, production).
Was this helpful? React with 👍 / 👎
| const EmailEventStorage = require('../email-service/email-event-storage'); | |
| const EmailEventStorage = require('../email-service/EmailEventStorage'); | |
| const EmailEventProcessor = require('../email-service/EmailEventProcessor'); |
- Apply suggested fix
| @@ -1,4 +1,4 @@ | |||
| import {DonationPaymentEvent} from './DonationPaymentEvent'; | |||
| import {DonationPaymentEvent} from './donation-payment-event'; | |||
There was a problem hiding this comment.
🚨 Bug: Broken require: DonationBookshelfRepository renamed but ref not updated
The file DonationBookshelfRepository.ts was renamed to donation-bookshelf-repository.ts in this PR, but donation-service-wrapper.js (line 11) still contains require('./DonationBookshelfRepository'). Since the file no longer exists at the PascalCase path, this will cause a MODULE_NOT_FOUND error when the donation service initializes.
The fix is to update the require in donation-service-wrapper.js to use the new kebab-case filename:
const {DonationBookshelfRepository} = require('./donation-bookshelf-repository');Was this helpful? React with 👍 / 👎
- Apply suggested fix
Code Review 🚫 Blocked 0 resolved / 2 findingsTwo critical broken require paths: 🚨 Bug: Broken requires: email-event-storage/processor files not renamed📄 ghost/core/core/server/services/email-analytics/email-analytics-service-wrapper.js:12 📄 ghost/core/core/server/services/email-analytics/email-analytics-service-wrapper.js:13 In On case-insensitive filesystems (macOS) this might not surface during local development, but it will fail on case-sensitive filesystems (Linux, CI, production). Suggested fix🚨 Bug: Broken require: DonationBookshelfRepository renamed but ref not updated📄 ghost/core/core/server/services/donations/donation-bookshelf-repository.ts:1 The file The fix is to update the require in const {DonationBookshelfRepository} = require('./donation-bookshelf-repository');OptionsAuto-apply is off → Gitar will not commit updates to this branch. Comment with these commands to change:
Was this helpful? React with 👍 / 👎 | Gitar |
3 participants
Benchmark PR for Gitar evaluation
Original PR: agentic-review-benchmarks#7
Continues refactoring service files to use kebab-case naming convention.