Skip to content

DeadCodeElimination-0197f2f0-1b53-75c3-b76a-81d27429defa #3451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

optimus-primal[bot]
Copy link

Gig
Ran track: This automated PR eliminates dead code.

Code Cleanup Details
  • android-test/src/test/kotlin/okhttp/android/test/RobolectricOkHttpClientTest.kt

    • Cleaned up code (5 times)
      • Deleted the unused variable context
      • Deleted unnecessary assignments to the variable context
      • Deleted unused imports (3 times)
  • build.gradle.kts

    • Cleaned up code
      • Deleted unused imports
  • mockwebserver-deprecated/src/test/java/okhttp3/mockwebserver/KotlinSourceModernTest.kt

    • Cleaned up code (60 times)
      • Deleted the unused variable bodyDelay
      • Deleted the unused variable bodySize
      • Deleted the unused variable body (2 times)
      • Deleted the unused variable chunkSizes
      • Deleted the unused variable dispatcher (2 times)
      • Deleted the unused variable handshake
      • Deleted the unused variable header
      • Deleted the unused variable headersDelay
      • Deleted the unused variable headers (3 times)
      • Deleted the unused variable hostName
      • Deleted the unused variable http2ErrorCode
      • Deleted the unused variable method (2 times)
      • Deleted the unused variable mockResponse
      • Deleted the unused variable nullableRequest
      • Deleted the unused variable path (2 times)
      • Deleted the unused variable port
      • Deleted the unused variable protocols
      • Deleted the unused variable pushPromise
      • Deleted the unused variable pushPromises
      • Deleted the unused variable recordedRequest
      • Deleted the unused variable requestCount
      • Deleted the unused variable requestLine
      • Deleted the unused variable requestUrl
      • Deleted the unused variable request
      • Deleted the unused variable response
      • Deleted the unused variable sequenceNumber
      • Deleted the unused variable settings
      • Deleted the unused variable socketPolicy (2 times)
      • Deleted the unused variable status
      • Deleted the unused variable throttleBytesPerPeriod
      • Deleted the unused variable throttlePeriod
      • Deleted the unused variable tlsVersion
      • Deleted the unused variable toProxyAddress
      • Deleted the unused variable trailers
      • Deleted the unused variable url
      • Deleted the unused variable utf8Body
      • Deleted the unused variable webSocketListener
      • Deleted unnecessary assignments to the variable dispatcher
      • Deleted unnecessary assignments to the variable hostName
      • Deleted unnecessary assignments to the variable mockResponse
      • Deleted unnecessary assignments to the variable pushPromises
      • Deleted unnecessary assignments to the variable recordedRequest
      • Deleted unnecessary assignments to the variable settings
      • Deleted unnecessary assignments to the variable status
      • Deleted unnecessary assignments to the variable throttleBytesPerPeriod
      • Deleted unnecessary assignments to the variable webSocketListener
      • Deleted unused imports (7 times)
  • okhttp-dnsoverhttps/src/main/kotlin/okhttp3/dnsoverhttps/DnsRecordCodec.kt

    • Cleaned up code (2 times)
      • Deleted the unused variable ASCII
      • Deleted the unused variable TYPE_PTR
  • okhttp/src/jvmTest/kotlin/okhttp3/CallHandshakeTest.kt

    • Cleaned up code (2 times)
      • Deleted the unused variable defaultSupportedCipherSuites
      • Deleted unnecessary assignments to the variable defaultSupportedCipherSuites
  • okhttp/src/jvmTest/kotlin/okhttp3/KotlinDeprecationErrorTest.kt

    • Cleaned up code (197 times)
      • Deleted the unused variable address (2 times)
      • Deleted the unused variable authParams
      • Deleted the unused variable authenticator
      • Deleted the unused variable body (3 times)
      • Deleted the unused variable boundary
      • Deleted the unused variable cacheControl (3 times)
      • Deleted the unused variable cacheResponse
      • Deleted the unused variable cache (2 times)
      • Deleted the unused variable callTimeoutMillis
      • Deleted the unused variable certificatePinner (2 times)
      • Deleted the unused variable certificate
      • Deleted the unused variable challenge
      • Deleted the unused variable charset
      • Deleted the unused variable cipherSuite (2 times)
      • Deleted the unused variable cipherSuites
      • Deleted the unused variable client
      • Deleted the unused variable code
      • Deleted the unused variable connectTimeoutMillis
      • Deleted the unused variable connectionPool
      • Deleted the unused variable connectionSpec
      • Deleted the unused variable connectionSpecs (2 times)
      • Deleted the unused variable cookieJar
      • Deleted the unused variable cookie
      • Deleted the unused variable directory
      • Deleted the unused variable dispatcher
      • Deleted the unused variable dns (2 times)
      • Deleted the unused variable domain
      • Deleted the unused variable encodedFragment
      • Deleted the unused variable encodedPassword
      • Deleted the unused variable encodedPathSegments
      • Deleted the unused variable encodedPath
      • Deleted the unused variable encodedQuery
      • Deleted the unused variable encodedUsername
      • Deleted the unused variable eventListenerFactory
      • Deleted the unused variable expiresAt
      • Deleted the unused variable followRedirects
      • Deleted the unused variable followSslRedirects
      • Deleted the unused variable formBody
      • Deleted the unused variable fragment
      • Deleted the unused variable getFromUri
      • Deleted the unused variable getFromUrl
      • Deleted the unused variable handshakeCertificates
      • Deleted the unused variable handshake (2 times)
      • Deleted the unused variable headers (6 times)
      • Deleted the unused variable heldCertificate
      • Deleted the unused variable hostOnly
      • Deleted the unused variable host
      • Deleted the unused variable hostnameVerifier (2 times)
      • Deleted the unused variable http2ErrorCode
      • Deleted the unused variable httpOnly
      • Deleted the unused variable httpUrl
      • Deleted the unused variable immutable
      • Deleted the unused variable inetSocketAddress
      • Deleted the unused variable interceptor
      • Deleted the unused variable interceptors
      • Deleted the unused variable javaName (2 times)
      • Deleted the unused variable keyManager
      • Deleted the unused variable keyPair
      • Deleted the unused variable level
      • Deleted the unused variable localCertificates
      • Deleted the unused variable localPrincipal
      • Deleted the unused variable maxAgeSeconds
      • Deleted the unused variable maxStaleSeconds
      • Deleted the unused variable mediaType
      • Deleted the unused variable message
      • Deleted the unused variable method (2 times)
      • Deleted the unused variable minFreshSeconds
      • Deleted the unused variable mockResponse
      • Deleted the unused variable multipartBody (2 times)
      • Deleted the unused variable mustRevalidate
      • Deleted the unused variable name
      • Deleted the unused variable networkInterceptors
      • Deleted the unused variable networkResponse
      • Deleted the unused variable noCache
      • Deleted the unused variable noStore
      • Deleted the unused variable noTransform
      • Deleted the unused variable onlyIfCached
      • Deleted the unused variable parse (3 times)
      • Deleted the unused variable part
      • Deleted the unused variable parts
      • Deleted the unused variable password
      • Deleted the unused variable pathSegments
      • Deleted the unused variable pathSize
      • Deleted the unused variable path (2 times)
      • Deleted the unused variable peerCertificates
      • Deleted the unused variable peerPrincipal
      • Deleted the unused variable persistent
      • Deleted the unused variable pingIntervalMillis
      • Deleted the unused variable port (2 times)
      • Deleted the unused variable priorResponse
      • Deleted the unused variable protocol
      • Deleted the unused variable protocols (2 times)
      • Deleted the unused variable proxyAuthenticator (2 times)
      • Deleted the unused variable proxySelector (2 times)
      • Deleted the unused variable proxy (3 times)
      • Deleted the unused variable pushPromise
      • Deleted the unused variable queryParameterNames
      • Deleted the unused variable queryParameter
      • Deleted the unused variable querySize
      • Deleted the unused variable query
      • Deleted the unused variable readTimeoutMillis
      • Deleted the unused variable realm
      • Deleted the unused variable receivedResponseAtMillis
      • Deleted the unused variable recordedRequest
      • Deleted the unused variable requestCount
      • Deleted the unused variable request (2 times)
      • Deleted the unused variable response (2 times)
      • Deleted the unused variable retryOnConnectionFailure
      • Deleted the unused variable route
      • Deleted the unused variable sMaxAgeSeconds
      • Deleted the unused variable scheme (2 times)
      • Deleted the unused variable secure
      • Deleted the unused variable sentRequestAtMillis
      • Deleted the unused variable size (3 times)
      • Deleted the unused variable socketFactory (2 times)
      • Deleted the unused variable socketPolicy
      • Deleted the unused variable sslSocketFactory (2 times)
      • Deleted the unused variable status
      • Deleted the unused variable subtype
      • Deleted the unused variable supportsTlsExtensions
      • Deleted the unused variable tlsVersion (2 times)
      • Deleted the unused variable tlsVersions
      • Deleted the unused variable trailers
      • Deleted the unused variable trustManager
      • Deleted the unused variable type (2 times)
      • Deleted the unused variable uri
      • Deleted the unused variable url (3 times)
      • Deleted the unused variable username
      • Deleted the unused variable utf8Body
      • Deleted the unused variable value
      • Deleted the unused variable writeTimeoutMillis
      • Deleted unnecessary assignments to the variable headers
      • Deleted unused imports (25 times)
  • okhttp/src/jvmTest/kotlin/okhttp3/KotlinSourceModernTest.kt

    • Cleaned up code (387 times)
      • Deleted the unused variable address (2 times)
      • Deleted the unused variable alternative
      • Deleted the unused variable authParams
      • Deleted the unused variable authenticator (2 times)
      • Deleted the unused variable basic (2 times)
      • Deleted the unused variable bodyDelay
      • Deleted the unused variable bodySize
      • Deleted the unused variable body (6 times)
      • Deleted the unused variable boundary
      • Deleted the unused variable builder (4 times)
      • Deleted the unused variable byteCount
      • Deleted the unused variable byteStream
      • Deleted the unused variable bytes
      • Deleted the unused variable cacheControl (4 times)
      • Deleted the unused variable cacheResponse
      • Deleted the unused variable cache
      • Deleted the unused variable callTimeoutMillis
      • Deleted the unused variable call (2 times)
      • Deleted the unused variable callback
      • Deleted the unused variable certificatePem
      • Deleted the unused variable certificatePinner (2 times)
      • Deleted the unused variable certificate
      • Deleted the unused variable certificates
      • Deleted the unused variable chain
      • Deleted the unused variable challenge
      • Deleted the unused variable challenges
      • Deleted the unused variable charStream
      • Deleted the unused variable charset (2 times)
      • Deleted the unused variable chunkSizes
      • Deleted the unused variable cipherSuite (2 times)
      • Deleted the unused variable cipherSuites
      • Deleted the unused variable client (2 times)
      • Deleted the unused variable code
      • Deleted the unused variable compatible
      • Deleted the unused variable connectTimeoutMillis
      • Deleted the unused variable connectionCount
      • Deleted the unused variable connectionPool
      • Deleted the unused variable connectionSpec (2 times)
      • Deleted the unused variable connectionSpecs (2 times)
      • Deleted the unused variable connection
      • Deleted the unused variable contentLength (2 times)
      • Deleted the unused variable contentType (2 times)
      • Deleted the unused variable cookieJar (2 times)
      • Deleted the unused variable cookie (2 times)
      • Deleted the unused variable cookies
      • Deleted the unused variable date
      • Deleted the unused variable defaultCharset
      • Deleted the unused variable defaultPort
      • Deleted the unused variable default (2 times)
      • Deleted the unused variable digest
      • Deleted the unused variable directory
      • Deleted the unused variable dispatcher (3 times)
      • Deleted the unused variable dns (2 times)
      • Deleted the unused variable domain
      • Deleted the unused variable encodedFragment
      • Deleted the unused variable encodedName
      • Deleted the unused variable encodedPassword
      • Deleted the unused variable encodedPathSegments
      • Deleted the unused variable encodedPath
      • Deleted the unused variable encodedQuery
      • Deleted the unused variable encodedUsername
      • Deleted the unused variable encodedValue
      • Deleted the unused variable eventListenerFactory
      • Deleted the unused variable eventListener (2 times)
      • Deleted the unused variable executorService
      • Deleted the unused variable expiresAt
      • Deleted the unused variable factory
      • Deleted the unused variable followRedirects
      • Deleted the unused variable followSslRedirects
      • Deleted the unused variable forceCache
      • Deleted the unused variable forceNetwork
      • Deleted the unused variable formBody
      • Deleted the unused variable form
      • Deleted the unused variable fragment
      • Deleted the unused variable getFromUri
      • Deleted the unused variable getFromUrl
      • Deleted the unused variable get (2 times)
      • Deleted the unused variable handshakeCertificates (2 times)
      • Deleted the unused variable handshake (3 times)
      • Deleted the unused variable header (3 times)
      • Deleted the unused variable headersDelay
      • Deleted the unused variable headersForName (2 times)
      • Deleted the unused variable headers (9 times)
      • Deleted the unused variable heldCertificate (2 times)
      • Deleted the unused variable hitCount
      • Deleted the unused variable hostName
      • Deleted the unused variable hostOnly
      • Deleted the unused variable host
      • Deleted the unused variable hostnameVerifier (2 times)
      • Deleted the unused variable http2ErrorCode
      • Deleted the unused variable httpOnly
      • Deleted the unused variable httpUrl (2 times)
      • Deleted the unused variable idleConnectionCount
      • Deleted the unused variable immutable
      • Deleted the unused variable inetSocketAddress
      • Deleted the unused variable instant
      • Deleted the unused variable interceptors (2 times)
      • Deleted the unused variable isHttps (2 times)
      • Deleted the unused variable javaName (2 times)
      • Deleted the unused variable keyManager
      • Deleted the unused variable keyPair
      • Deleted the unused variable level
      • Deleted the unused variable listOfCertificates
      • Deleted the unused variable loadForRequest
      • Deleted the unused variable localCertificates
      • Deleted the unused variable localPrincipal
      • Deleted the unused variable loggingEventListener
      • Deleted the unused variable matches
      • Deleted the unused variable maxAgeSeconds
      • Deleted the unused variable maxRequestsPerHost
      • Deleted the unused variable maxRequests
      • Deleted the unused variable maxSize
      • Deleted the unused variable maxStaleSeconds
      • Deleted the unused variable mediaType
      • Deleted the unused variable message
      • Deleted the unused variable method (3 times)
      • Deleted the unused variable minFreshSeconds
      • Deleted the unused variable mixed
      • Deleted the unused variable mockResponse
      • Deleted the unused variable multimap
      • Deleted the unused variable multipartBody
      • Deleted the unused variable mustRevalidate
      • Deleted the unused variable name (3 times)
      • Deleted the unused variable names
      • Deleted the unused variable networkCount
      • Deleted the unused variable networkInterceptors (2 times)
      • Deleted the unused variable networkResponse
      • Deleted the unused variable newBuilder
      • Deleted the unused variable noCache
      • Deleted the unused variable noStore
      • Deleted the unused variable noTransform
      • Deleted the unused variable none (2 times)
      • Deleted the unused variable nullableRequest
      • Deleted the unused variable onlyIfCached
      • Deleted the unused variable parallel
      • Deleted the unused variable parse (3 times)
      • Deleted the unused variable parsedCookie
      • Deleted the unused variable part (2 times)
      • Deleted the unused variable parts
      • Deleted the unused variable password
      • Deleted the unused variable pathSegments
      • Deleted the unused variable pathSize
      • Deleted the unused variable path (3 times)
      • Deleted the unused variable peekBody
      • Deleted the unused variable peerCertificates
      • Deleted the unused variable peerPrincipal
      • Deleted the unused variable persistent
      • Deleted the unused variable pin
      • Deleted the unused variable pingIntervalMillis
      • Deleted the unused variable port (2 times)
      • Deleted the unused variable priorResponse
      • Deleted the unused variable privateKeyPkcs1Pem
      • Deleted the unused variable privateKeyPkcs8Pem
      • Deleted the unused variable protocol (2 times)
      • Deleted the unused variable protocols (3 times)
      • Deleted the unused variable proxyAuthenticator (2 times)
      • Deleted the unused variable proxySelector (2 times)
      • Deleted the unused variable proxy (2 times)
      • Deleted the unused variable pushPromise
      • Deleted the unused variable pushPromises
      • Deleted the unused variable queryParameterName
      • Deleted the unused variable queryParameterNames
      • Deleted the unused variable queryParameterValue
      • Deleted the unused variable queryParameterValues
      • Deleted the unused variable queryParameter
      • Deleted the unused variable querySize
      • Deleted the unused variable query
      • Deleted the unused variable queuedCallsCount
      • Deleted the unused variable queuedCalls
      • Deleted the unused variable readTimeoutMillis
      • Deleted the unused variable realm
      • Deleted the unused variable receivedResponseAtMillis
      • Deleted the unused variable recordedRequest
      • Deleted the unused variable redact
      • Deleted the unused variable redirect
      • Deleted the unused variable requestBody (3 times)
      • Deleted the unused variable requestCount (2 times)
      • Deleted the unused variable requestLine
      • Deleted the unused variable requestUrl
      • Deleted the unused variable request (5 times)
      • Deleted the unused variable requiresTunnel
      • Deleted the unused variable resolveBuilder
      • Deleted the unused variable resolve
      • Deleted the unused variable response (4 times)
      • Deleted the unused variable retryOnConnectionFailure
      • Deleted the unused variable route
      • Deleted the unused variable runningCallsCount
      • Deleted the unused variable runningCalls
      • Deleted the unused variable sMaxAgeSeconds
      • Deleted the unused variable scheme (2 times)
      • Deleted the unused variable secure
      • Deleted the unused variable sentRequestAtMillis
      • Deleted the unused variable sequenceNumber
      • Deleted the unused variable settings
      • Deleted the unused variable size (4 times)
      • Deleted the unused variable socketFactory (2 times)
      • Deleted the unused variable socketPolicy (2 times)
      • Deleted the unused variable source
      • Deleted the unused variable sslContext
      • Deleted the unused variable sslSocketFactory (3 times)
      • Deleted the unused variable status
      • Deleted the unused variable stringTag
      • Deleted the unused variable string
      • Deleted the unused variable subtype
      • Deleted the unused variable successful
      • Deleted the unused variable supportsTlsExtensions
      • Deleted the unused variable system
      • Deleted the unused variable tag
      • Deleted the unused variable throttleBytesPerPeriod
      • Deleted the unused variable throttlePeriod
      • Deleted the unused variable tlsVersion (3 times)
      • Deleted the unused variable tlsVersions
      • Deleted the unused variable toProxyAddress
      • Deleted the unused variable topPrivateDomain
      • Deleted the unused variable trailers (2 times)
      • Deleted the unused variable trustManager
      • Deleted the unused variable type (2 times)
      • Deleted the unused variable uri
      • Deleted the unused variable url (4 times)
      • Deleted the unused variable urls
      • Deleted the unused variable username
      • Deleted the unused variable utf8Body
      • Deleted the unused variable utf8
      • Deleted the unused variable value (3 times)
      • Deleted the unused variable values
      • Deleted the unused variable webSocketListener (2 times)
      • Deleted the unused variable webSocket (2 times)
      • Deleted the unused variable writeAbortCount
      • Deleted the unused variable writeSuccessCount
      • Deleted the unused variable writeTimeoutMillis
      • Deleted unnecessary assignments to the variable challenge
      • Deleted unnecessary assignments to the variable cipherSuite
      • Deleted unnecessary assignments to the variable connectionSpec (3 times)
      • Deleted unnecessary assignments to the variable dispatcher
      • Deleted unnecessary assignments to the variable factory (2 times)
      • Deleted unnecessary assignments to the variable handshake
      • Deleted unnecessary assignments to the variable headers
      • Deleted unnecessary assignments to the variable hostName
      • Deleted unnecessary assignments to the variable mockResponse
      • Deleted unnecessary assignments to the variable part (5 times)
      • Deleted unnecessary assignments to the variable protocol
      • Deleted unnecessary assignments to the variable pushPromises
      • Deleted unnecessary assignments to the variable recordedRequest
      • Deleted unnecessary assignments to the variable requestBody (10 times)
      • Deleted unnecessary assignments to the variable request
      • Deleted unnecessary assignments to the variable settings
      • Deleted unnecessary assignments to the variable status
      • Deleted unnecessary assignments to the variable stringTag
      • Deleted unnecessary assignments to the variable tag
      • Deleted unnecessary assignments to the variable throttleBytesPerPeriod
      • Deleted unnecessary assignments to the variable tlsVersion
      • Deleted unnecessary assignments to the variable webSocketListener
      • Deleted unused imports (21 times)
  • samples/guide/src/main/java/okhttp3/recipes/HttpsServer.java

    • Cleaned up code
      • Deleted unused imports

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant