FuzzerTrue-0194896d-22e4-7b63-910d-6258e2323bc3 #6644
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![optimus-primal[bot]](https://avatars.githubusercontent.com/in/956879?s=60&v=4){kind=small}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gig
seed=8948127177261462410prob=0.99Ran track: This automated PR permanently enables the
GITAR_PLACEHOLDERfeature flag.Summary of Changes
Gitar found and removed uses of the
GITAR_PLACEHOLDERfeature flag across 15 files. Some of these files include:datavec/datavec-api/src/main/java/org/datavec/api/records/writer/impl/csv/CSVRecordWriter.javadeeplearning4j/deeplearning4j-nlp-parent/deeplearning4j-nlp/src/main/java/org/deeplearning4j/models/sequencevectors/serialization/VocabWordFactory.javand4j/nd4j-backends/nd4j-api-parent/nd4j-api/src/main/java/org/nd4j/autodiff/functions/DifferentialFunction.javand4j/nd4j-backends/nd4j-api-parent/nd4j-api/src/main/java/org/nd4j/linalg/dataset/api/iterator/TestDataSetIterator.javaplatform-tests/src/test/java/org/nd4j/jita/allocator/DeviceLocalNDArrayTests.javaGitar performed deep cleanup and code optimizations triggered by the feature flag removal in all of these files.
Finally, after propagating cleanups across files, Gitar found additional cleanup opportunities in 60 other files.
Code Cleanup Details
codegen/libnd4j-gen/src/main/java/org/nd4j/descriptor/proposal/impl/JavaSourceArgDescriptorSource.javamethodInvokedtrueto calls of the functionequals(25 times)datavec/datavec-api/src/main/java/org/datavec/api/records/writer/impl/csv/CSVRecordWriter.javadelimBytesdelimBytesdatavec/datavec-data/datavec-data-image/src/main/java/org/datavec/image/transform/PipelineImageTransform.javadatavec/datavec-local/src/main/java/org/datavec/local/transforms/AnalyzeLocal.javadeeplearning4j/deeplearning4j-modelimport/src/main/java/org/deeplearning4j/nn/modelimport/keras/layers/core/KerasActivation.javadeeplearning4j/deeplearning4j-nlp-parent/deeplearning4j-nlp/src/main/java/org/deeplearning4j/models/sequencevectors/serialization/VocabWordFactory.javarettrueto uses of the variableretdeeplearning4j/deeplearning4j-nn/src/main/java/org/deeplearning4j/nn/conf/layers/recurrent/Bidirectional.javalayerNametrueto calls of the functionisPretrainParamdeeplearning4j/deeplearning4j-nn/src/main/java/org/deeplearning4j/nn/conf/layers/wrapper/BaseWrapperLayer.javadeeplearning4j/deeplearning4j-nn/src/main/java/org/deeplearning4j/nn/layers/BaseLayer.javatrueto calls of the functionhasBias(2 times)deeplearning4j/deeplearning4j-nn/src/main/java/org/deeplearning4j/nn/layers/BaseOutputLayer.javabiasGradViewfullNetRegTermfullNetRegTermsolvertrueto uses of the variablebiasGradView(2 times)trueto uses of the variableweightGradView(2 times)nd4j/nd4j-backends/nd4j-api-parent/nd4j-api/src/main/java/org/nd4j/autodiff/functions/DifferentialFunction.javaensureProperTypeisConfigPropertiesneedsConfigureargs(2 times)foutputVarsvalsnd4j/nd4j-backends/nd4j-api-parent/nd4j-api/src/main/java/org/nd4j/autodiff/samediff/SDVariable.javaa1a2trueto calls of the functionequals(2 times)nd4j/nd4j-backends/nd4j-api-parent/nd4j-api/src/main/java/org/nd4j/autodiff/samediff/SameDiff.javaeqOpseqVarsreverseArgssameDifftrueto calls of the functionequals(11 times)trueto calls of the functionneedsConfiguretrueto uses of the variableeqOpstrueto uses of the variableeqVarsnd4j/nd4j-backends/nd4j-api-parent/nd4j-api/src/main/java/org/nd4j/autodiff/samediff/internal/AbstractSession.javatrueto calls of the functionequals(5 times)nd4j/nd4j-backends/nd4j-api-parent/nd4j-api/src/main/java/org/nd4j/autodiff/samediff/internal/InferenceSession.javainputShapeArrshape(2 times)trueto calls of the functionequals(10 times)trueto calls of the functionneedsConfigurend4j/nd4j-backends/nd4j-api-parent/nd4j-api/src/main/java/org/nd4j/autodiff/samediff/serde/FlatBuffersMapper.javatrueto calls of the functionequalsnd4j/nd4j-backends/nd4j-api-parent/nd4j-api/src/main/java/org/nd4j/autodiff/samediff/transform/GraphTransformUtil.javatrueto calls of the functionequalstrueto calls of the functionmatchesnd4j/nd4j-backends/nd4j-api-parent/nd4j-api/src/main/java/org/nd4j/autodiff/samediff/transform/OpPredicate.javatrueto calls of the functionequals(2 times)trueto calls of the functionmatches(2 times)nd4j/nd4j-backends/nd4j-api-parent/nd4j-api/src/main/java/org/nd4j/autodiff/samediff/transform/SubGraphPredicate.javatrueto calls of the functionmatches(3 times)nd4j/nd4j-backends/nd4j-api-parent/nd4j-api/src/main/java/org/nd4j/autodiff/util/SameDiffUtils.javatrueto calls of the functionequalsnd4j/nd4j-backends/nd4j-api-parent/nd4j-api/src/main/java/org/nd4j/autodiff/validation/GradCheckUtil.javatrueto calls of the functionequals(2 times)nd4j/nd4j-backends/nd4j-api-parent/nd4j-api/src/main/java/org/nd4j/imports/converters/DifferentialFunctionClassHolder.javatrueto calls of the functionisConfigPropertiesnd4j/nd4j-backends/nd4j-api-parent/nd4j-api/src/main/java/org/nd4j/imports/descriptors/properties/adapters/ConditionalFieldValueIntIndexArrayAdapter.javacomptrueto calls of the functionequalsnd4j/nd4j-backends/nd4j-api-parent/nd4j-api/src/main/java/org/nd4j/imports/descriptors/properties/adapters/ConditionalFieldValueNDArrayShapeAdapter.javacompPropertytrueto calls of the functionequalsnd4j/nd4j-backends/nd4j-api-parent/nd4j-api/src/main/java/org/nd4j/imports/descriptors/properties/adapters/StringEqualsAdapter.javabtrueto calls of the functionequalstrueto uses of the variablebnd4j/nd4j-backends/nd4j-api-parent/nd4j-api/src/main/java/org/nd4j/imports/descriptors/properties/adapters/StringNotEqualsAdapter.javabfalseto uses of the variablebtrueto calls of the functionequalsnd4j/nd4j-backends/nd4j-api-parent/nd4j-api/src/main/java/org/nd4j/linalg/api/ops/BaseOp.javatrueto calls of the functionequals(5 times)nd4j/nd4j-backends/nd4j-api-parent/nd4j-api/src/main/java/org/nd4j/linalg/api/ops/custom/Invoke.javatrueto calls of the functionequalsnd4j/nd4j-backends/nd4j-api-parent/nd4j-api/src/main/java/org/nd4j/linalg/api/ops/impl/controlflow/compat/Exit.javand4j/nd4j-backends/nd4j-api-parent/nd4j-api/src/main/java/org/nd4j/linalg/api/ops/impl/layers/convolution/AvgPooling2D.javaisConfigPropertiesnd4j/nd4j-backends/nd4j-api-parent/nd4j-api/src/main/java/org/nd4j/linalg/api/ops/impl/layers/convolution/AvgPooling3D.javaisConfigPropertiesnd4j/nd4j-backends/nd4j-api-parent/nd4j-api/src/main/java/org/nd4j/linalg/api/ops/impl/layers/convolution/Conv1D.javaisConfigPropertiesnd4j/nd4j-backends/nd4j-api-parent/nd4j-api/src/main/java/org/nd4j/linalg/api/ops/impl/layers/convolution/Conv1DDerivative.javaisConfigPropertiesnd4j/nd4j-backends/nd4j-api-parent/nd4j-api/src/main/java/org/nd4j/linalg/api/ops/impl/layers/convolution/Conv2D.javaisConfigPropertiesnd4j/nd4j-backends/nd4j-api-parent/nd4j-api/src/main/java/org/nd4j/linalg/api/ops/impl/layers/convolution/Conv3D.javaisConfigPropertiesnd4j/nd4j-backends/nd4j-api-parent/nd4j-api/src/main/java/org/nd4j/linalg/api/ops/impl/layers/convolution/DeConv2D.javaisConfigPropertiesnd4j/nd4j-backends/nd4j-api-parent/nd4j-api/src/main/java/org/nd4j/linalg/api/ops/impl/layers/convolution/DeConv2DTF.javaisConfigPropertiesnd4j/nd4j-backends/nd4j-api-parent/nd4j-api/src/main/java/org/nd4j/linalg/api/ops/impl/layers/convolution/DeConv3D.javaisConfigPropertiesnd4j/nd4j-backends/nd4j-api-parent/nd4j-api/src/main/java/org/nd4j/linalg/api/ops/impl/layers/convolution/DeConv3DTF.javaisConfigPropertiesnd4j/nd4j-backends/nd4j-api-parent/nd4j-api/src/main/java/org/nd4j/linalg/api/ops/impl/layers/convolution/DepthwiseConv2D.javaisConfigPropertiesnd4j/nd4j-backends/nd4j-api-parent/nd4j-api/src/main/java/org/nd4j/linalg/api/ops/impl/layers/convolution/DepthwiseConv2DBp.javaisConfigPropertiesnd4j/nd4j-backends/nd4j-api-parent/nd4j-api/src/main/java/org/nd4j/linalg/api/ops/impl/layers/convolution/LocalResponseNormalization.javaisConfigPropertiesnd4j/nd4j-backends/nd4j-api-parent/nd4j-api/src/main/java/org/nd4j/linalg/api/ops/impl/layers/convolution/MaxPoolWithArgmax.javaisConfigPropertiesnd4j/nd4j-backends/nd4j-api-parent/nd4j-api/src/main/java/org/nd4j/linalg/api/ops/impl/layers/convolution/MaxPooling2D.javaisConfigPropertiesnd4j/nd4j-backends/nd4j-api-parent/nd4j-api/src/main/java/org/nd4j/linalg/api/ops/impl/layers/convolution/MaxPooling3D.javaisConfigPropertiesnd4j/nd4j-backends/nd4j-api-parent/nd4j-api/src/main/java/org/nd4j/linalg/api/ops/impl/layers/convolution/Pooling2D.javaisConfigPropertiesnd4j/nd4j-backends/nd4j-api-parent/nd4j-api/src/main/java/org/nd4j/linalg/api/ops/impl/layers/convolution/Pooling3D.javaisConfigPropertiesnd4j/nd4j-backends/nd4j-api-parent/nd4j-api/src/main/java/org/nd4j/linalg/api/ops/impl/layers/convolution/SConv2D.javaisConfigPropertiesnd4j/nd4j-backends/nd4j-api-parent/nd4j-api/src/main/java/org/nd4j/linalg/api/ops/impl/layers/recurrent/LSTMLayer.javaisConfigPropertiesnd4j/nd4j-backends/nd4j-api-parent/nd4j-api/src/main/java/org/nd4j/linalg/api/ops/impl/layers/recurrent/LSTMLayerBp.javaisConfigPropertiesnd4j/nd4j-backends/nd4j-api-parent/nd4j-api/src/main/java/org/nd4j/linalg/api/ops/impl/reduce/Mmul.javaisConfigPropertiesnd4j/nd4j-backends/nd4j-api-parent/nd4j-api/src/main/java/org/nd4j/linalg/api/ops/impl/reduce/custom/BatchMmul.javaneedsConfigurend4j/nd4j-backends/nd4j-api-parent/nd4j-api/src/main/java/org/nd4j/linalg/api/ops/impl/transforms/strict/GELU.javarettrueto uses of the variableretnd4j/nd4j-backends/nd4j-api-parent/nd4j-api/src/main/java/org/nd4j/linalg/api/ops/impl/transforms/strict/Swish.javarettrueto uses of the variableretnd4j/nd4j-backends/nd4j-api-parent/nd4j-api/src/main/java/org/nd4j/linalg/dataset/api/iterator/BaseDatasetIterator.javatrueto calls of the functionhasNextnd4j/nd4j-backends/nd4j-api-parent/nd4j-api/src/main/java/org/nd4j/linalg/dataset/api/iterator/CachingDataSetIterator.javatrueto calls of the functionhasNextnd4j/nd4j-backends/nd4j-api-parent/nd4j-api/src/main/java/org/nd4j/linalg/dataset/api/iterator/MultipleEpochsIterator.javalognumPassespassesnumPassespassestrueto calls of the functionasyncSupportedtrueto calls of the functionhasNext(3 times)trueto calls of the functionresetSupportednd4j/nd4j-backends/nd4j-api-parent/nd4j-api/src/main/java/org/nd4j/linalg/dataset/api/iterator/StandardScaler.javatrueto calls of the functionhasNextnd4j/nd4j-backends/nd4j-api-parent/nd4j-api/src/main/java/org/nd4j/linalg/dataset/api/iterator/TestDataSetIterator.javadtrueto uses of the variabled(2 times)nd4j/nd4j-backends/nd4j-api-parent/nd4j-api/src/main/java/org/nd4j/linalg/lossfunctions/SameDiffLoss.javagradAtInputlabelslayerInputoutput(2 times)scoreArrtrueto uses of the variablegradAtInput(2 times)trueto uses of the variablelabelstrueto uses of the variablelayerInputtrueto uses of the variableoutput(2 times)trueto uses of the variablescoreArr(2 times)nd4j/nd4j-backends/nd4j-backend-impls/nd4j-cpu-backend-common/src/main/java/org/nd4j/linalg/cpu/nativecpu/ops/NativeOpExecutioner.javanshape2stride2trueto calls of the functionequals(4 times)platform-tests/src/test/java/org/eclipse/deeplearning4j/dl4jcore/nn/layers/convolution/Convolution3DTest.javagetContainedDatatrueto calls of the functiongetContainedDatatrueto uses of the variablecontainedInputplatform-tests/src/test/java/org/eclipse/deeplearning4j/dl4jcore/nn/layers/convolution/ConvolutionLayerTest.javainputtrueto calls of the functiongetContainedDatatrueto uses of the variableinputplatform-tests/src/test/java/org/eclipse/deeplearning4j/dl4jcore/nn/layers/convolution/SpaceToDepthTest.javagetContainedDatacontainedInputtrueto calls of the functiongetContainedData(3 times)trueto uses of the variablecontainedExpectedOuttrueto uses of the variablecontainedInputplatform-tests/src/test/java/org/eclipse/deeplearning4j/dl4jcore/nn/layers/convolution/SubsamplingLayerTest.javacontainedInput(2 times)inputtrueto calls of the functiongetContainedData(4 times)trueto uses of the variablecontainedInput(2 times)trueto uses of the variableinput(2 times)platform-tests/src/test/java/org/eclipse/deeplearning4j/dl4jcore/nn/layers/convolution/Upsampling1DTest.javagetContainedDatacontainedInputtrueto calls of the functiongetContainedData(2 times)trueto uses of the variablecontainedInputtrueto uses of the variableinputplatform-tests/src/test/java/org/eclipse/deeplearning4j/dl4jcore/nn/layers/convolution/Upsampling2DTest.javagetContainedDatadepthexpectedContainedEpsilonInputinput2rettrueto uses of the variableconftrueto uses of the variablecontainedExpectedOuttrueto uses of the variablecontainedOutputtrueto uses of the variabledepth(2 times)trueto uses of the variableexpectedContainedEpsilonInputtrueto uses of the variableexpectedContainedEpsilonResulttrueto uses of the variableinput2trueto uses of the variableinputtrueto uses of the variableretplatform-tests/src/test/java/org/eclipse/deeplearning4j/frameworkimport/tensorflow/TFGraphTestAllHelper.javaconfigurationsameDiffPredictionssdPredictionstrueto calls of the functionequals(15 times)x -> trueto references of the functionequalsplatform-tests/src/test/java/org/eclipse/deeplearning4j/nd4j/autodiff/opvalidation/TestTransformOpValidation.javaexpectedShapeshapeOktrueto calls of the functionequals(3 times)trueto uses of the variableshapeOkplatform-tests/src/test/java/org/eclipse/deeplearning4j/nd4j/autodiff/samediff/GraphTransformUtilTests.javasubtrueto calls of the functionmatches(9 times)platform-tests/src/test/java/org/eclipse/deeplearning4j/nd4j/linalg/dataset/NormalizerMinMaxScalerTest.javatrueto calls of the functionhasNextplatform-tests/src/test/java/org/eclipse/deeplearning4j/nd4j/linalg/dataset/NormalizerStandardizeLabelsTest.javatrueto calls of the functionhasNextplatform-tests/src/test/java/org/eclipse/deeplearning4j/nd4j/linalg/dataset/NormalizerStandardizeTest.javatrueto calls of the functionhasNextplatform-tests/src/test/java/org/eclipse/deeplearning4j/nd4j/linalg/dataset/NormalizerTests.javatrueto calls of the functionhasNextplatform-tests/src/test/java/org/nd4j/jita/allocator/DeviceLocalNDArrayTests.javaarr(2 times)f(3 times)trueto uses of the variablearr(2 times)trueto uses of the variablef(3 times)