.github/workflows: don't clear Cloudflare cache unless configured #1895
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dscho
reviewed
Oct 2, 2024
The recent change in 0d22411 (.github/workflows: purge Cloudflare cache on deployment, 2024-10-01) will cause deployment workflows run in forks of git/git-scm.com to fail, since they will likely not have a Cloudflare token configured in their repository secrets. Let's make use of a suggestion from Johannes[1] and only run this step when the repository is configured with a Cloudflare token. Note that we can't directly write: if: ${{ secrets.CLOUDFLARE_TOKEN != '' }} , because repository secrets cannot be used in job step-level conditionals[2]. Instead, the GitHub Actions documentation recommends setting the secret as an environment variable, and then using the presence (or absence) of that environment variable's contents as a proxy to determine whether or not the secret is set. All together, this should un-break deployment workflows in forks of git/git-scm.com for repositories that have not set up a Cloudflare token. [1]: #1893 (review) [2]: https://docs.github.com/en/actions/writing-workflows/workflow-syntax-for-github-actions#example-using-secrets Suggested-by: Johannes Schindelin <Johannes.Schindelin@gmx.de> Signed-off-by: Taylor Blau <me@ttaylorr.com>
ttaylorr
force-pushed
the
ttaylorr/purge-cloudflare-cache-not-in-forks
branch
from
5cb2ac2
to
da01731
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The recent change in 0d22411 (.github/workflows: purge Cloudflare cache on deployment, 2024-10-01) will cause deployment workflows run in forks of git/git-scm.com to fail, since they will likely not have a Cloudflare token configured in their repository secrets.
Let's make use of a suggestion from Johannes1 and only run this step when the repository is configured with a Cloudflare token.
Note that we can't directly write:
, because repository secrets cannot be used in job step-level conditionals2. Instead, the GitHub Actions documentation recommends setting the secret as an environment variable, and then using the presence (or absence) of that environment variable's contents as a proxy to determine whether or not the secret is set.
All together, this should un-break deployment workflows in forks of git/git-scm.com for repositories that have not set up a Cloudflare token.
Suggested-by: Johannes Schindelin Johannes.Schindelin@gmx.de
/cc @dscho