Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update links to book images #1390

Merged
merged 1 commit into from
Oct 30, 2019
Merged

Update links to book images #1390

merged 1 commit into from
Oct 30, 2019

Conversation

Hirse
Copy link
Contributor

@Hirse Hirse commented Oct 30, 2019

Some links to book preview images on External Links are broken.
This PR replaces the broken links with working ones to packtpub.

Some of the other images seem to be served with the website. Should that be done for all of them to prevent this in the future?

image

@pedrorijo91
Copy link
Member

I think it's not the first time this happens. Maybe we should indeed save the images. Or having a cron task to check image links are not broken. Merging as it solves the problem for now

@pedrorijo91
Copy link
Member

thanks for the contribution @Hirse :)

@pedrorijo91 pedrorijo91 merged commit e953df5 into git:master Oct 30, 2019
@Hirse Hirse deleted the book-images branch October 30, 2019 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants