Repository navigation
Use 1 pt steps for the text size slider - #2830
Merged
lucasderraugh merged 1 commit intoOct 8, 2026
Merged
Conversation
The text size slider in Preferences only offered 8 sizes (9, 10, 11, 12, 13, 14, 18 and 24 pt), so above 14 pt it jumped straight to 18 and then 24, making it impossible to pick an in-between size. The slider now offers every point size from 9 to 24 pt (16 tick marks) and is 20 pt wider so the denser tick marks stay easy to hit. Existing values (9-14, 18 and 24) keep mapping to the same size, so no user setting changes after updating.
|
lucasderraugh
approved these changes
Oct 8, 2026
lucasderraugh
left a comment
Collaborator
There was a problem hiding this comment.
Sounds good to me
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Text Size slider in Preferences only offered 8 sizes: 9, 10, 11, 12, 13, 14, 18 and 24 pt. Above 14 pt it jumped straight to 18 and then 24, so there was no way to pick an in-between size such as 16 pt.
This PR makes the slider offer every point size from 9 to 24 pt (16 tick marks).
Changes
FontSizeTransformer.m— the size table now lists every size from 9 to 24 pt.PreferencesWindowController.xib— the slider has 16 tick marks (maxValue15) and is 20 pt wider (186 → 206), so the denser tick marks stay easy to hit. The large "Aa" label still fits inside the window.Compatibility
Existing values (9–14, 18 and 24 pt) map to the same sizes as before, so no one's setting changes after updating. Values set externally that aren't in the table keep the existing fallback behavior.
Testing
Applicationscheme, Debug).GIUserDefaultKey_FontSize.