Repository navigation
Honor checkpoint tombstones in bounded node liveness (#894) - #935
Conversation
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 6 minutes. View limit detailsLimit details: You’ve used the included review currently available. Review configuration: ⚙️ Run configuration
📒 Files selected for processing (5)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Code Lawyer activity summary — head
Manual SSJS: the existing checkpoint reader validates the receipt; the existing node scan owns dot liveness; the locator binds consumed shards into read identity. No host capability, ambient time/entropy, message parsing or casts added. This is a behavior correction, not a claim of full-module coverage or a general checkpoint refactor. All acceptance execution used COPY-only Docker without host repository/Git mounts. Independent exact-head review and hosted CI remain outstanding; this is not merge approval. |
Release PreflightHead:
npm bundle analysis
Warnings begin at 85% of a limit; critical headroom begins at 95%. Exceeding a limit fails the existing payload gate.
Findings (0)No static inspection findings. Static reachability findings are deletion candidates, not proof that a file is safe to remove. Dependency checks cover imports and manifest declarations; they are not a vulnerability audit. Largest files (unpacked)
A release-branch merge still requires final preflight and the normal release workflow. |
Independent Codex review — PR #935PR: #935 Exact reviewed head: I performed the authorized independent Codex substitute for agy, applying the full agy-review mandatory protocol and output contract. This implementation belongs to the parent agent. No reviewed source, comments, branches or configuration were modified; no subagents were used. Approval does not authorize merging. FindingsNo verified P0–P5 defects in this exact-head change. The floating removed-dot discrepancy is reproduced, the corrected bounded result agrees with independent expected membership and full JoinReducer replay, and missing evidence refuses instead of assuming an add survives. Verification ChecklistLockdown, history, scope and live feedback
Every changed behavior and production path
Errors, transitions, resource constraints and compatibility
Assertions, raw evidence and every numeric claim
Coverage limitations and merge gateNo mandatory source-review area for this focused change remains unavailable. The new floating-dot fixture is production-writer/locator integration, not a claim of a separately executed root Runtime end-to-end workflow. Existing public optic conformance was independently executed. No fuzz distribution, affected-user population, full heap bound, crash durability or full-module 100% coverage is claimed. Source acceptance for #894 is satisfied at this exact head; normal local gates and hosted checks are green. Root must preserve current-head review/CI and repository protections and record the eventual main integration before closing the issue. This report grants no merge authorization. APPROVE |
Main integration preparationMerged current main The normal full COPY-Docker push gate is running before publication. An exact-head independent integration review is requested; fresh hosted checks will also gate merge. This comment does not claim the unpublished head is already accepted or integrated. |
Independent Codex integration review — PR #935Exact current head: No new verified defect. The original four non-changelog paths remain byte-identical, the incoming ownership model stays test-only, and the guide expressly separates byte capability from structural ownership. Source review approves this head. New hosted checks are running and remain a separate merge blocker; the previous head's successful CI is not current-head evidence. This report does not authorize merging. Original exact-head review retained as historical evidence — PR #935PR: #935 Exact reviewed head: I performed the authorized independent Codex substitute for agy, applying the full agy-review mandatory protocol and output contract. This implementation belongs to the parent agent. No reviewed source, comments, branches or configuration were modified; no subagents were used. Approval does not authorize merging. FindingsNo verified P0–P5 defects in this exact-head change. The floating removed-dot discrepancy is reproduced, the corrected bounded result agrees with independent expected membership and full JoinReducer replay, and missing evidence refuses instead of assuming an add survives. Verification ChecklistLockdown, history, scope and live feedback
Every changed behavior and production path
Errors, transitions, resource constraints and compatibility
Assertions, raw evidence and every numeric claim
Coverage limitations and merge gateNo mandatory source-review area for this focused change remains unavailable. The new floating-dot fixture is production-writer/locator integration, not a claim of a separately executed root Runtime end-to-end workflow. Existing public optic conformance was independently executed. No fuzz distribution, affected-user population, full heap bound, crash durability or full-module 100% coverage is claimed. Source acceptance for #894 is satisfied at this exact head; normal local gates and hosted checks are green. Root must preserve current-head review/CI and repository protections and record the eventual main integration before closing the issue. This report grants no merge authorization. Integration Verification Checklist at the current head
APPROVE |
Outcome
Closes #894. A checkpoint remove may already observe a dot whose add arrives later in the tail. The bounded node read previously treated every tail add as alive and could resurrect that removed node.
Node reads now consume the checkpoint lifecycle receipt’s floating tombstones and include that evidence in their read identity. A tail add without lifecycle evidence refuses with the existing structured bounded-basis cause. Existing refusal for tail node removes remains intact; unchanged legacy checkpoint membership remains readable. No materialization fallback or checkpoint format change is introduced.
Validation
All executable checks use COPY-based Docker without host repository/Git mounts.
Independent exact-head review and hosted CI remain required before merge.