🚨 CRITICAL: Oracle Security Fix - Remove Default Paths

[samscarrow]

🔒 Critical Security Fix

This PR addresses security vulnerabilities in the Oracle database configuration by removing all default paths and enforcing environment variable usage.

Security Issues Fixed

1. Removed default paths that exposed system structure:

   • /home/sam/git/photosight/wallet (exposed username and project structure)
   • /usr/lib (exposed system architecture)

2. Enforced environment variables for all sensitive configuration

3. Added validation to fail fast if required variables are missing

Changes

• Remove all default values for paths in Oracle configuration
• Add validate_config() method to check required environment variables
• Call validation before any connection attempt
• Provide clear error messages when configuration is incomplete

Breaking Changes

Oracle connection now requires these environment variables:

• ORACLE_USER
• ORACLE_PASSWORD
• ORACLE_TNS_ADMIN
• ORACLE_CLIENT_PATH

Migration Guide

Set the following in your .env file:

ORACLE_USER=your_user
ORACLE_PASSWORD=your_password
ORACLE_TNS_ADMIN=/path/to/wallet
ORACLE_CLIENT_PATH=/path/to/oracle/client

Testing

• Verify connection fails with clear error when env vars are missing
• Verify connection succeeds when all env vars are set
• No sensitive data in error messages

---

⚠️ This is a critical security fix and should be merged immediately.

[github-actions]

🤖 Claude Code Review Error

Sorry, I encountered an error while reviewing this PR:

Please check the workflow logs for more details.

[github-actions]

❌ Claude Code Review Failed: Please check the workflow logs for details.

[Copilot]

Pull Request Overview

This PR implements a critical security fix for Oracle database configuration by removing hardcoded default paths that exposed sensitive system information and enforcing the use of environment variables for all configuration values.

• Removed hardcoded default paths that exposed username, project structure, and system architecture
• Added validation method to ensure all required environment variables are set before connection attempts
• Enforced environment variable usage for Oracle client path, TNS admin path, and wallet configuration

---

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.}

[Copilot]

This condition check creates inconsistent behavior. The validate_config() method requires TNS_ADMIN to be set (line 40-41), but this line only sets the environment variable if it exists. This means the validation will fail if TNS_ADMIN is missing, but the connection code assumes it might be optional.

Suggested change

	os.environ['TNS_ADMIN'] = cls.TNS_ADMIN
	# Ensure TNS_ADMIN is set in environment (guaranteed by validation)
	os.environ['TNS_ADMIN'] = cls.TNS_ADMIN

[Copilot]

The comment 'if available' is misleading since the validate_config() method now requires TNS_ADMIN to be set. The comment should reflect that this is a required configuration, not optional.

Suggested change

	# Ensure TNS_ADMIN is set in environment if available
	# Ensure TNS_ADMIN is set in environment (required)