simple Go modules cleanup #95
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We match our dependency versions to those in our vendor directory as listed in commit 00c176d, and use Go 1.11 to match the main git-lfs repository. Then we run "go mod tidy" and "go mod vendor" which simplifies the contents of our vendor directory a bit.
bk2204
approved these changes
Sep 18, 2020
|
Do you know any pruduction implemention repo,thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a very basic cleanup of the Go modules used in this repo, and explicitly not an update of them. They are still vendored at the 5-year-old revisions they've been at for a while, we just now have
go.{mod,sum}and can do a bit of tidying withgo mod tidy && go mod vendor.Updates would be nice, of course, but might also introduce breakage, and since this isn't a maintained production system, just having enough to run
go buildon my dev instance is really all I was aiming for.I also added
lfs.dbto.gitignoreas it's generated by thelfs-test-serverbinary if you run it right in your Git working tree.