netrc.go: consider same machine may have different login names #1
+63
−22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bk2204
approved these changes
Sep 14, 2021
Member
bk2204
left a comment
bk2204
left a comment
There was a problem hiding this comment.
Thanks for the patch. This looks good.
Once we've released 3.0.0, I'll bump the version in the main repository.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git-lfs client currently only use the first machine that matched without considering login name.
git-lfs/git-lfs#4324
This commit make it act like git. Which would also check login name if specified.
If login name is not given, it would pick the first machine that matched.