revise download buttons and add Apple Silicon option on macOS #51
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the advent of Apple's M1-based systems we now need to offer two download options for macOS users on our home page, as there is no convenient and reliable way to distinguish between hardware platforms in JavaScript. Therefore we add a second "Apple Silicon" download button for macOS users, and rename the original button "Intel Silicon". Rather than try to continue the existing practice of sharing the HTML code for the first download button with Windows, we refactor the download button HTML into three sections, one each for Windows, macOS, and Linux. This in turn allows us to delete the "js-os-data" CoffeeScript as each HTML section is now fully independent. Having made this change for macOS, it also makes some sense for us to make a parallel change for Linux users, promoting the Intel/AMD x86-64 download option to a button aligned below the packagecloud.io install option button. Because we now have two primary download options for macOS, and for Linux as well, we drop the hyperlink around the "Download" text in the our set of instructions for new users, as it is not useful to have that text always link to just one of several possible download options. Lastly we add some simple whitespace-based padding just to make some of our text strings align slightly better in both the macOS and Linux versions of the home page.
bk2204
approved these changes
Feb 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the advent of Apple's M1-based systems we now need to offer two download options for macOS users on our home page, as there is no convenient and reliable way to distinguish between hardware platforms in JavaScript.
Therefore we add a second "Apple Silicon" download button for macOS users, and rename the original button "Intel Silicon".
Rather than try to continue the existing practice of sharing the HTML code for the first download button with Windows, we refactor the download button HTML into three sections, one each for Windows, macOS, and Linux. This in turn allows us to delete the
js-os-dataCoffeeScript as each HTML section is now fully independent.Having made this change for macOS, it also makes some sense for us to make a parallel change for Linux users, promoting the Intel/AMD x86-64 download option to a button aligned below the packagecloud.io install option button.
Because we now have two primary download options for macOS, and for Linux as well, we drop the hyperlink around the "Download" text in the our set of instructions for new users, as it is not useful to have that text always link to just one of several possible download options.
Lastly we add some simple whitespace-based padding just to make some of our text strings align slightly better in both the macOS and Linux versions of the home page.
The macOS version of the page now renders as:
The Linux version now renders as:
And the Windows version continues to render as it does currently:
Fixes git-lfs/git-lfs#4836.
/cc @tecandrew as reporter.