Bug: Cannot kill Nodejs process using ctrl + c

[gyandeeps]

• I was not able to find an open or closed issue matching what I'm seeing

Setup

• Which version of Git for Windows are you using? Is it 32-bit or 64-bit?

$ git --version --build-options

git version 2.13.1.windows.2
built from commit: a36e14b3aaa0ddb633c40a9c8483e6fe12d99616
sizeof-long: 4
machine: x86_64

• Which version of Windows are you running? Vista, 7, 8, 10? Is it 32-bit or 64-bit?

Windows 7

$ cmd.exe /c ver

Microsoft Windows [Version 6.1.7601]

• What options did you set as part of the installation? Or did you choose the
  defaults?

# One of the following:
> type "C:\Program Files\Git\etc\install-options.txt"
> type "C:\Program Files (x86)\Git\etc\install-options.txt"
> type "%USERPROFILE%\AppData\Local\Programs\Git\etc\install-options.txt"
$ cat /etc/install-options.txt

Path Option: BashOnly
SSH Option: OpenSSH
CURL Option: OpenSSL
CRLF Option: LFOnly
Bash Terminal Option: MinTTY
Performance Tweaks FSCache: Enabled
Use Credential Manager: Enabled
Enable Symlinks: Disabled

• Any other interesting things about your environment that might be related
  to the issue you're seeing?

• Using Nodejs - 8.1.2

Details

• Which terminal/shell are you running Git from? e.g Bash/CMD/PowerShell/other

Bash

• What commands did you run to trigger this issue? If you can provide a
  Minimal, Complete, and Verifiable example
  this will help us understand the issue.

Steps:

• Create a js file with content

const http = require('http');
const fs = require('fs');
const port = 3000;
const app = http.createServer((req,res) => {
    res.writeHead(200);
    res.end("hi");
});

app.listen(port);

its a simple server running on 3000 port.

• Run command "node ./app.js" inside git bash.
• hit "CTRL + c" (2 times) to kill the process.
• If you look at taskmanager, then you will see a node.js process
  still running. or if you try to restart the server it will say port
  300 already in use.

• What did you expect to occur after running these commands?

If you look at taskmanager, then you will see a node.js process still running. or if you try to restart the server it will say port 300 already in use.

• What actually happened instead?

The nodejs process still running.

Notes:

• It was working fine on first release of git 2.13. It broken with releases after that.

git version 2.13.0.windows.1
built from commit: eba7af3dbb4c846c6303c5f64102acee696c9ab0
sizeof-long: 4
machine: x86_64

[dscho]

So this has been reported to the Git mailing list: https://public-inbox.org/git/CAHaNChecHzZqzafe4P85Kz4BtJuisO+krCvm=yPW9wGMXWJK_A@mail.gmail.com/t/#m014eb20edd8dbe7f0bd41527f031c7e578747d9e

And I responded there, too:

On Mon, 26 Jun 2017, Gyandeep Singh wrote:

3. hit "CTRL + c" (2 times) to kill the process.
4. If you look at taskmanager, then you will see a node.js process
   still running. or if you try to restart the server it will say port
   300 already in use.

The way Ctrl+C is handled in Git for Windows changed recently, indeed.

Remember: sending signals to processes to ask them to terminate is POSIX
semantics. Not Windows semantics.

On Windows you can terminate a process via the Win32 API. And I really
mean "terminate". There is no chance for that process to, say, remove a
now-stale .git/index.lock.

We have to jump through hoops to accomodate Git's lack of non-POSIX
understandings. In this particular case, we inject a remote thread into
the process, running ExitProcess() so that the atexit() handlers have a
chance to perform the cleanup that Git so cleverly expects to be able to
do when being terminated.

It is probably that thread that is still trying to run when you hit Ctrl+C
the second time, and that second time it terminates just the shadow
process: node.exe is a Console program, and since you run it in Git Bash
(which does not have a Win32 Console, but emulates a Unix terminal
instead) the node shell alias runs node.exe through a helper called
winpty.exe that I suspect gets terminated without taking down its child
processes.

[gyandeeps]

is the decision that the behavior present in git version 2.13.0.windows.1 was not correct. That incorrect behavior has been fixed now. Sorry I am little confused.

[gyandeeps]

@dscho Just wanted to check-in to understand whether this is something considered a bug and will be fixed in future or this is the expected behavior? thanks

[gyandeeps]

ping...

[dscho]

The previous behavior was to terminate processes instead of killing them, I.e. now processes get a chance to clean up before exiting.This fixed the very real bug that .lock files were left behind, as I explained.

It is not clear from your description what goes wrong, as information such as "bitness" of the node.js let alone instructions how to reproduce this issue easily & quickly is missing.

[gyandeeps]

I am sorry but i think I have given the instruction in the issue (Details -> Steps). What are you looking for other than that?

[dscho]

What are you looking for other than that?

Time.

[begin-again]

I am having the same issue.
git --version = git version 2.14.1.windows.1
bash --version = GNU bash, version 4.4.12(1)-release (x86_64-pc-msys)
node --version = 8.4.0
mintty v2.7.7 (x86_64-pc-msys)
Windows 10

if I run either of these scripts in PowerShell, ctrl+c works as expected in that the nodejs process exits and is no longer visible in the task manager.

"scripts": {
    "start": "nodemon --watch views --watch public --watch routes ./bin/www ",
    "test": "karma start karma.conf.js --no-single-run"

The start script is starting up an expressjs web app. When I type ctrl+c one or more times in Git-Bash, I see a line feed for each, but the process does not exit. I can type 'rs' to restart nodemon and it responds. I have to close GitBash manually by clicking the close button or alt+f4 and then kill the nodejs jobs in the task manager.

The test script will respond to a ctrl+c by returning to the prompt. It looks like it exited, but a check of the task manager shows that it is actually still running.

[dscho]

The start script is starting up an expressjs web app.

Is this running as a 32-bit or as a 64-bit process?

[begin-again]

Nodejs is 64-bit if that is what you mean.

[dscho]

Nodejs is 64-bit if that is what you mean.

What I meant is the process (even 64-bit software is know to execute 32-bit code from time to time, e.g. Git for Windows' installer is always 32-bit).

But I guess 64-bit node.js will run 64-bit processes.

Hrm.

Can you kill -9 <pid> (find the pid using ps -W)?

[zaggino]

Having the same issue using latest Git for Windows 2.14.1
Using latest Node 64-bit for Windows 8.5.0
Basically any node.js application that I start will keep running after ctrl+C
I can kill the process using Task Manager but that's not really a solution.
Reverting to 2.12.2.2 fixes the problem.