Fix download button href replace #76
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jQuery was dropped. Link: #62 Replace download button href replace to `getElementById` Signed-off-by: Coia Prant <coiaprant@gmail.com>
dscho
added a commit
to dscho/git-for-windows.github.io
that referenced
this pull request
Jun 2, 2025
In git-for-windows#76, I merged a contribution that purported to fix the problem that the download button no longer pointed to the appropriate installer. The underlying root cause is that that logic relied on jQuery, but we recently got rid of it (because our copy was ridiculously outdated). The problem with that PR is that it had an incomplete solution, still leaving `$(...)` calls in place. This here commit fixes that. Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
dscho
reviewed
Jun 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
jQuery was dropped
Link: #62
Replace download button href replace to
getElementById