build-installers: do include the 7-Zip DLL #530
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In 537c34a (Stop using p7zip, use 7-Zip instead, 2023-08-25), I switched Git for Windows to using the MINGW variant of 7-Zip instead of the MSYS variant of p7zip. However, there was a quite obvious mistake where I specified 7z.exe to be included in the `build-installers` sdk-artifact _twice_, and 7z.dll not at all. The intention was to specify both, one time each, which is what this here commit does. Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
|
The symptom of the bug fixed by this here PR can be seen here: https://github.com/git-for-windows/git-sdk-32/actions/runs/6167519248/job/16739133510#step:7:37 |
rimrul
added a commit
to rimrul/git
that referenced
this pull request
Oct 11, 2023
We've switched from p7zip to regular 7-Zip recently[1][2][3]. With that we don't need to monitor p7zip for updates anymore, but we want to stay informed about 7-Zip updates now. Change the feed accordingly. Since the new feed contains 15 different files as separate items for the latest 7-Zip update, aggregate them into a single issue. [1] git-for-windows/build-extra#526 [2] git-for-windows/build-extra#527 [3] git-for-windows/build-extra#530 Signed-off-by: Matthias Aßhauer <mha1993@live.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a brown paper bag fix for #527