Skip to content

Add GCM_INTERACTIVE/credential.interactive setting #91

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 31, 2020

Conversation

mjcheetham
Copy link
Collaborator

Add a setting to disable all user interaction. By setting GCM_INTERACTIVE or credential.interactive to a 'falsey' value, GCM Core will now fail and return an error if user interaction is required.

This is useful in headless and unattended environments, such as build servers, where is is preferable to fail than it is to hang waiting for input from a non-existent user.

The setting also existed in the previous GCM for Windows, but its behaviour has been slightly modified to treat 'always' values as 'auto'. See more in the documentation and the code.

The default value is true / permit interaction.

Closed #90.

@mjcheetham mjcheetham added the enhancement New feature or request label Jan 31, 2020
Copy link
Contributor

@derrickstolee derrickstolee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix a documentation bug and you're good to go!

@mjcheetham mjcheetham force-pushed the nointeractive branch 2 times, most recently from d7be010 to ebbcbba Compare January 31, 2020 15:51
@mjcheetham
Copy link
Collaborator Author

/azp run GCM-PR

@azure-pipelines
Copy link

No pipelines are associated with this pull request.

Add a setting to disable all user interaction. By setting
`GCM_INTERACTIVE` or `credential.interactive` to a 'falsey' value, GCM
Core will now fail and return an error if user interaction is required.

This is useful in headless and unattended environments, such as build
servers, where is is preferable to fail than it is to hang waiting for
input from a non-existent user.

The setting also existed in the previous GCM for Windows, but its
behaviour has been slightly modified to treat 'always' values as 'auto'.
See more in the documentation and the code.

The default value is `true` / permit interaction.
@mjcheetham mjcheetham merged commit 21abaa0 into git-ecosystem:master Jan 31, 2020
@mjcheetham mjcheetham deleted the nointeractive branch January 31, 2020 16:53
@mjcheetham mjcheetham mentioned this pull request Apr 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Setting to disable interactive/modal auth
2 participants