Skip to content

Set up infrastructure for wingetcreate #483

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 12, 2021
Merged

Set up infrastructure for wingetcreate #483

merged 2 commits into from
Oct 12, 2021

Conversation

ldennington
Copy link
Contributor

Overview

This change sets up the infrastructure for GCM Core to support deployments to microsoft/winget-pkgs via wingetcreate. Specifically:

  1. We update the release-winget workflow to run on Windows Server instead of Ubuntu (required since wingetcreate is a Windows executable).
  2. We update the GCM Core inno installer metadata to be correct/compatible with wingetcreate.
  3. Add quotes to InnoSetup paths to support spaces.

Testing

I tested this change with the following steps:

  1. Build a local copy of the installer
  2. Publish the locally-built copy as a faux pre-release
  3. Run wingetcreate new against the faux pre-release
  4. Verify generated manifests align with specifications in #700

Associated work items

#699
#700

@ldennington
Run release-winget on Windows Server
40f5934 
`wingetcreate` is a Windows exe and thus must be run on Windows. Updating
our release-winget workflow accordingly.
@ldennington ldennington requested a review from mjcheetham October 8, 2021 17:54
@ldennington ldennington self-assigned this Oct 8, 2021
@ldennington
Update inno installer metadata
624251e 
Updating inno installer metadata to align with the specification outlined in
github/git-fundamentals#700. Also adding
appropriate quotations to `Installer.Windows.csproj` to handle paths with
spaces.
@ldennington ldennington merged commit 53ea286 into git-ecosystem:main Oct 12, 2021
@derrickstolee derrickstolee mentioned this pull request Oct 13, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mjcheetham mjcheetham mjcheetham approved these changes

Assignees

@ldennington ldennington

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ldennington @mjcheetham