Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create release for GCM 2.4.0 #1457

Merged
merged 66 commits into from
Nov 1, 2023
Merged
Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
66 commits
Select commit Hold shift + click to select a range
6676986
x509: add utils to find certs by thumbprint
mjcheetham Aug 7, 2023
b627044
msauth: rename GetTokenAsync to GetTokenForUserAsync
mjcheetham Aug 3, 2023
89b099e
msauth: abstract token cache init helpers
mjcheetham Aug 8, 2023
6a90c36
msauth: add support for service principal auth
mjcheetham Aug 7, 2023
bfa87db
msauth: add support for managed identity
mjcheetham Aug 7, 2023
f00c859
msauth: add MSAL app token cache support for CCAs
mjcheetham Aug 8, 2023
aafbda4
azrepos: support service principals and managed IDs
mjcheetham Aug 7, 2023
eff4ea6
azrepos: add tests of MID and SP get credential
mjcheetham Aug 15, 2023
0704b42
release.yml: use correct target_commitish arg
mjcheetham Aug 16, 2023
a74fe18
release.yml: use correct target_commitish arg (#1381)
mjcheetham Aug 16, 2023
488aa48
Support managed identities and service principals (#1372)
mjcheetham Aug 16, 2023
527c41b
Use Avalonia 11.0.3
de1acr0ix Aug 17, 2023
cd0a34c
Update to Avalonia 11.0.4
de1acr0ix Aug 19, 2023
3fb216d
release: update homebrew deployment
ldennington Aug 19, 2023
e076f58
release: update homebrew deployment (#1386)
ldennington Aug 21, 2023
9902e8f
dependencies: update to Avalonia 11.0.4 (#1383)
ldennington Aug 28, 2023
b501b8b
github: support gist remote URLs for GitHub
mjcheetham Sep 5, 2023
afcb6b8
Support gist remote URLs for GitHub (#1402)
mjcheetham Sep 6, 2023
3774413
bitbucket: drop WPF-based UI helper for Bitbucket
mjcheetham Sep 11, 2023
7828213
github: drop WPF-based UI helper for GitHub
mjcheetham Sep 11, 2023
63133c9
gitlab: drop WPF-based UI helper for GitLab
mjcheetham Sep 11, 2023
11b5d50
gcm-ui: drop WPF-based UI helper for shared UI
mjcheetham Sep 11, 2023
8a098a4
wpf: drop shared WPF library
mjcheetham Sep 11, 2023
5c50a73
Support linux install path from src
m4ss1m0g Sep 12, 2023
53e2b48
install from source: custom install location edits
ldennington Sep 18, 2023
03a23a1
docs: update dev.azure.com product page URLs
mjcheetham Sep 18, 2023
e66805c
Merge pull request #1 from ldennington/install-from-source-suggestions
m4ss1m0g Sep 19, 2023
fde8bbd
Update dev.azure.com product page URLs (#1416)
mjcheetham Sep 19, 2023
c99ef6d
build(deps): bump DavidAnson/markdownlint-cli2-action
dependabot[bot] Sep 19, 2023
01ce22b
build(deps): bump DavidAnson/markdownlint-cli2-action from 11.0.0 to …
mjcheetham Sep 19, 2023
8f925d3
build(deps): bump actions/checkout from 3 to 4
dependabot[bot] Sep 19, 2023
6fbc243
build(deps): bump actions/checkout from 3 to 4 (#1397)
mjcheetham Sep 19, 2023
1e904d1
msauth: replace WPF progress window with Avalonia
mjcheetham Sep 11, 2023
24c1883
build(deps): bump DavidAnson/markdownlint-cli2-action
dependabot[bot] Sep 20, 2023
6e49d9e
build(deps): bump DavidAnson/markdownlint-cli2-action from 12.0.0 to …
ldennington Sep 21, 2023
ac0b264
Drop WPF-based UI helpers on Windows (#1417)
mjcheetham Sep 21, 2023
3b6b07d
install from source: refactor install location
ldennington Sep 25, 2023
720d347
install from source: correct path addition
ldennington Sep 25, 2023
e1064f3
avalonia: remove workaround for devtools and app lifetime
mjcheetham Sep 26, 2023
54f6b46
Merge pull request #2 from ldennington/linux-install-fixes
m4ss1m0g Oct 2, 2023
f4f3689
recognise GitLab hosts by WWW-Authenticate header
hickford Oct 3, 2023
531d7ed
release: change dotnet to .NET and loosen version requirements
ldennington Oct 6, 2023
5562307
release: add permissions and prereqs
ldennington Oct 6, 2023
27d7636
release: update Linux to use GPG signing
ldennington Oct 7, 2023
16e628a
release: update macOS signing
ldennington Oct 12, 2023
4d3a8f1
release: update Windows to use Azure Code Signing
ldennington Oct 10, 2023
961a213
release: update .NET tool azure connection/variables
ldennington Oct 7, 2023
8f93d56
release: validate linux signatures
ldennington Oct 16, 2023
d0ae441
recognise GitLab hosts by WWW-Authenticate header (#1428)
ldennington Oct 18, 2023
12ab89b
recognise BitBucket hosts by WWW-Authenticate header
hickford Oct 19, 2023
ba2dcec
recognise BitBucket hosts by WWW-Authenticate header (#1441)
mjcheetham Oct 19, 2023
62eb6ab
Support linux install path from src (#1409)
ldennington Oct 19, 2023
c512d1b
use universal Gitea OAuth configuration
hickford Oct 19, 2023
46810df
avalonia: introduce flag to switch to SW rendering
mjcheetham Sep 28, 2023
2fd111b
release: update Linux, macOS, and Windows signing (#1431)
ldennington Oct 21, 2023
ee35d7b
default OAuth redirect URI to http://127.0.0.1
hickford Oct 20, 2023
66292a9
Apply suggestions from code review
hickford Oct 23, 2023
6e06153
use universal Gitea OAuth configuration (#1442)
mjcheetham Oct 24, 2023
e549586
default OAuth redirect URI to http://127.0.0.1 (#1444)
mjcheetham Oct 24, 2023
3183801
settings: default SW rendering on Windows+ARM
mjcheetham Oct 23, 2023
81211fb
platformutils: drop unnecessary netfx #ifdefs
mjcheetham Oct 25, 2023
b30eab3
Add software rendering flag for Windows (#1445)
mjcheetham Oct 25, 2023
59f01d9
platformutils: drop unnecessary netfx #ifdefs (#1447)
mjcheetham Oct 25, 2023
d928878
avalonia: actually setup Avalonia before starting
mjcheetham Oct 30, 2023
97a217d
avalonia: actually setup Avalonia before starting (#1453)
mjcheetham Oct 30, 2023
3a60ecf
version: bump to 2.4.0
mjcheetham Nov 1, 2023
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions src/shared/Core/Core.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -14,24 +14,24 @@
<Reference Include="System.Net.Http" />
<Reference Include="System.Web" />
<PackageReference Include="Microsoft.Identity.Client.Broker" Version="4.54.0" />
<PackageReference Include="Avalonia.Win32" Version="11.0.0-preview6" />
<PackageReference Include="Avalonia.Win32" Version="11.0.4" />
</ItemGroup>

<ItemGroup Condition="'$(TargetFramework)' != 'net472'">
<PackageReference Include="Avalonia.Desktop" Version="11.0.0-preview6" />
<PackageReference Include="Avalonia.Desktop" Version="11.0.4" />
</ItemGroup>

<ItemGroup>
<PackageReference Include="Microsoft.Identity.Client" Version="4.54.0" />
<PackageReference Include="Microsoft.Identity.Client.Extensions.Msal" Version="2.28.0" />
<PackageReference Include="System.CommandLine" Version="2.0.0-beta4.22272.1" />
<PackageReference Include="Avalonia" Version="11.0.0-preview6" />
<PackageReference Include="Avalonia.Skia" Version="11.0.0-preview6" />
<PackageReference Include="Avalonia.Themes.Fluent" Version="11.0.0-preview6" />
<PackageReference Include="Avalonia" Version="11.0.4" />
<PackageReference Include="Avalonia.Skia" Version="11.0.4" />
<PackageReference Include="Avalonia.Themes.Fluent" Version="11.0.4" />
</ItemGroup>

<ItemGroup Condition="'$(Configuration)' == 'Debug'">
<PackageReference Include="Avalonia.Diagnostics" Version="11.0.0-preview6" />
<PackageReference Include="Avalonia.Diagnostics" Version="11.0.4" />
</ItemGroup>

</Project>
4 changes: 2 additions & 2 deletions src/shared/Core/UI/AvaloniaUi.cs
Original file line number Diff line number Diff line change
Expand Up @@ -124,11 +124,11 @@ private static void SetParentExternal(Window window, IntPtr parentHandle)
return;
}

IntPtr ourHandle = window.PlatformImpl.Handle.Handle;
IntPtr ourHandle = window.TryGetPlatformHandle()!.Handle;

// Get the desktop scaling factor from our window instance so we
// can calculate rects correctly for both our window, and the parent window.
double scaling = window.PlatformImpl.DesktopScaling;
double scaling = window.RenderScaling;

// Get our window rect
var ourRect = new PixelRect(
Expand Down
16 changes: 5 additions & 11 deletions src/shared/GitHub/UI/Controls/SixDigitInput.axaml.cs
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
using Avalonia.Controls;
using Avalonia.Data;
using Avalonia.Input;
using Avalonia.Input.Platform;
using Avalonia.Interactivity;
using Avalonia.Markup.Xaml;
using GitCredentialManager;
Expand All @@ -22,8 +21,6 @@ public partial class SixDigitInput : UserControl, IFocusable
(o, v) => o.Text = v,
defaultBindingMode: BindingMode.TwoWay);

private PlatformHotkeyConfiguration _keyMap;
private IClipboard _clipboard;
private bool _ignoreTextBoxUpdate;
private TextBox[] _textBoxes;
private string _text;
Expand All @@ -37,8 +34,6 @@ private void InitializeComponent()
{
AvaloniaXamlLoader.Load(this);

_keyMap = AvaloniaLocator.Current.GetService<PlatformHotkeyConfiguration>();
_clipboard = AvaloniaLocator.Current.GetService<IClipboard>();
_textBoxes = new[]
{
this.FindControl<TextBox>("one"),
Expand Down Expand Up @@ -89,7 +84,7 @@ public void SetFocus()
{
// Workaround: https://github.com/git-ecosystem/git-credential-manager/issues/1293
if (!PlatformUtils.IsMacOS())
KeyboardDevice.Instance.SetFocusedElement(_textBoxes[0], NavigationMethod.Tab, KeyModifiers.None);
_textBoxes[0].Focus(NavigationMethod.Tab, KeyModifiers.None);
}

private void SetUpTextBox(TextBox textBox)
Expand All @@ -99,7 +94,7 @@ private void SetUpTextBox(TextBox textBox)
void OnPreviewKeyDown(object sender, KeyEventArgs e)
{
// Handle paste
if (_keyMap.Paste.Any(x => x.Matches(e)))
if (TopLevel.GetTopLevel(this)?.PlatformSettings?.HotkeyConfiguration.Paste.Any(x => x.Matches(e)) ?? false)
{
OnPaste();
e.Handled = true;
Expand Down Expand Up @@ -166,8 +161,7 @@ void OnPreviewKeyDown(object sender, KeyEventArgs e)

private void OnPaste()
{
string text = _clipboard.GetTextAsync().GetAwaiter().GetResult();
Text = text;
Text = TopLevel.GetTopLevel(this)?.Clipboard?.GetTextAsync().GetAwaiter().GetResult();
}

private bool MoveNext() => MoveFocus(true);
Expand All @@ -177,7 +171,7 @@ private void OnPaste()
private bool MoveFocus(bool next)
{
// Get currently focused text box
if (FocusManager.Instance.Current is TextBox textBox)
if (TopLevel.GetTopLevel(this)?.FocusManager?.GetFocusedElement() is TextBox textBox)
{
int textBoxIndex = Array.IndexOf(_textBoxes, textBox);
if (textBoxIndex > -1)
Expand All @@ -186,7 +180,7 @@ private bool MoveFocus(bool next)
? Math.Min(_textBoxes.Length - 1, textBoxIndex + 1)
: Math.Max(0, textBoxIndex - 1);

KeyboardDevice.Instance.SetFocusedElement(_textBoxes[nextIndex], NavigationMethod.Tab, KeyModifiers.None);
_textBoxes[nextIndex].Focus(NavigationMethod.Tab, KeyModifiers.None);
return true;
}
}
Expand Down
2 changes: 1 addition & 1 deletion src/shared/GitHub/UI/Views/SelectAccountView.axaml
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@
</StackPanel>

<StackPanel Orientation="Vertical" VerticalAlignment="Center">
<ListBox Items="{Binding Accounts}"
<ListBox ItemsSource="{Binding Accounts}"
SelectedItem="{Binding SelectedAccount}"
Margin="20,0,20,10"
MaxHeight="200"
Expand Down