settings: pull generic 'get' methods up to interface

Pull the general `TryGetSetting` and `GetSettingValues` methods up from
the `Settings` class to the `ISettings` interface for all providers to
use for their own settings.

src/shared/Microsoft.Git.CredentialManager/Settings.cs

@@ -15,6 +15,27 @@ namespace Microsoft.Git.CredentialManager
     /// </summary>
     public interface ISettings : IDisposable
     {
+        /// <summary>
+        /// Try and get the value of a specified setting as specified in the environment and Git configuration,
+        /// with the environment taking precedence over Git.
+        /// </summary>
+        /// <param name="envarName">Optional environment variable name.</param>
+        /// <param name="section">Optional Git configuration section name.</param>
+        /// <param name="property">Git configuration property name. Required if <paramref name="section"/> is set, optional otherwise.</param>
+        /// <param name="value">Value of the requested setting.</param>
+        /// <returns>True if a setting value was found, false otherwise.</returns>
+        bool TryGetSetting(string envarName, string section, string property, out string value);
+
+        /// <summary>
+        /// Try and get the all values of a specified setting as specified in the environment and Git configuration,
+        /// in the correct order or precedence.
+        /// </summary>
+        /// <param name="envarName">Optional environment variable name.</param>
+        /// <param name="section">Optional Git configuration section name.</param>
+        /// <param name="property">Git configuration property name. Required if <paramref name="section"/> is set, optional otherwise.</param>
+        /// <returns>All values for the specified setting, in order of precedence, or an empty collection if no such values are set.</returns>
+        IEnumerable<string> GetSettingValues(string envarName, string section, string property);
+
         /// <summary>
         /// Git repository that local configuration lookup is scoped to, or null if this instance is not scoped to a repository.
         /// </summary>
@@ -112,6 +133,124 @@ public Settings(IEnvironment environment, IGit git, string repositoryPath = null
             RepositoryPath = repositoryPath;
         }
 
+        public bool TryGetSetting(string envarName, string section, string property, out string value)
+        {
+            IEnumerable<string> allValues = GetSettingValues(envarName, section, property);
+
+            value = allValues.FirstOrDefault();
+
+            return value != null;
+        }
+
+        public IEnumerable<string> GetSettingValues(string envarName, string section, string property)
+        {
+            string value;
+
+            if (envarName != null)
+            {
+                if (_environment.Variables.TryGetValue(envarName, out value))
+                {
+                    yield return value;
+                }
+            }
+
+            if (section != null && property != null)
+            {
+                IGitConfiguration config = GetGitConfiguration();
+
+                if (RemoteUri != null)
+                {
+                    /*
+                     * Look for URL scoped "section" configuration entries, starting from the most specific
+                     * down to the least specific (stopping before the TLD).
+                     *
+                     * In a divergence from standard Git configuration rules, we also consider matching URL scopes
+                     * without a scheme ("protocol://").
+                     *
+                     * For each level of scope, we look for an entry with the scheme included (the default), and then
+                     * also one without it specified. This allows you to have one configuration scope for both "http" and
+                     * "https" without needing to repeat yourself, for example.
+                     *
+                     * For example, starting with "https://foo.example.com/bar/buzz" we have:
+                     *
+                     *   1a. [section "https://foo.example.com/bar/buzz"]
+                     *          property = value
+                     *
+                     *   1b. [section "foo.example.com/bar/buzz"]
+                     *          property = value
+                     *
+                     *   2a. [section "https://foo.example.com/bar"]
+                     *          property = value
+                     *
+                     *   2b. [section "foo.example.com/bar"]
+                     *          property = value
+                     *
+                     *   3a. [section "https://foo.example.com"]
+                     *          property = value
+                     *
+                     *   3b. [section "foo.example.com"]
+                     *          property = value
+                     *
+                     *   4a. [section "https://example.com"]
+                     *          property = value
+                     *
+                     *   4b. [section "example.com"]
+                     *          property = value
+                     *
+                     */
+
+                    // Enumerate all configuration entries with the correct section and property name
+                    // and make a local copy of them here to avoid needing to call `TryGetValue` on the
+                    // IGitConfiguration object multiple times in a loop below.
+                    var configEntries = new Dictionary<string, string>();
+                    config.Enumerate((entryName, entryValue) =>
+                    {
+                        string entrySection = entryName.TruncateFromIndexOf('.');
+                        string entryProperty = entryName.TrimUntilLastIndexOf('.');
+
+                        if (StringComparer.OrdinalIgnoreCase.Equals(entrySection, section) &&
+                            StringComparer.OrdinalIgnoreCase.Equals(entryProperty, property))
+                        {
+                            configEntries[entryName] = entryValue;
+                        }
+
+                        // Continue the enumeration
+                        return true;
+                    });
+
+                    foreach (string scope in RemoteUri.GetGitConfigurationScopes())
+                    {
+                        string queryName = $"{section}.{scope}.{property}";
+                        // Look for a scoped entry that includes the scheme "protocol://example.com" first as this is more specific
+                        if (configEntries.TryGetValue(queryName, out value))
+                        {
+                            yield return value;
+                        }
+
+                        // Now look for a scoped entry that omits the scheme "example.com" second as this is less specific
+                        string scopeWithoutScheme = scope.TrimUntilIndexOf(Uri.SchemeDelimiter);
+                        string queryWithSchemeName = $"{section}.{scopeWithoutScheme}.{property}";
+                        if (configEntries.TryGetValue(queryWithSchemeName, out value))
+                        {
+                            yield return value;
+                        }
+                    }
+                }
+
+                /*
+                 * Try to look for an un-scoped "section" property setting:
+                 *
+                 *    [section]
+                 *        property = value
+                 *
+                 */
+                if (config.TryGetValue($"{section}.{property}", out value))
+                {
+                    yield return value;
+                }
+            }
+        }
+
         public string RepositoryPath { get; }
 
         public Uri RemoteUri { get; set; }
@@ -279,141 +418,6 @@ bool TryGetUriSetting(string envarName, string section, string property, out Uri
 
         public string ParentWindowId => _environment.Variables.TryGetValue(Constants.EnvironmentVariables.GcmParentWindow, out string parentWindowId) ? parentWindowId : null;
 
-        /// <summary>
-        /// Try and get the value of a specified setting as specified in the environment and Git configuration,
-        /// with the environment taking precedence over Git.
-        /// </summary>
-        /// <param name="envarName">Optional environment variable name.</param>
-        /// <param name="section">Optional Git configuration section name.</param>
-        /// <param name="property">Git configuration property name. Required if <paramref name="section"/> is set, optional otherwise.</param>
-        /// <param name="value">Value of the requested setting.</param>
-        /// <returns>True if a setting value was found, false otherwise.</returns>
-        public bool TryGetSetting(string envarName, string section, string property, out string value)
-        {
-            IEnumerable<string> allValues = GetSettingValues(envarName, section, property);
-
-            value = allValues.FirstOrDefault();
-
-            return value != null;
-        }
-
-        /// <summary>
-        /// Try and get the all values of a specified setting as specified in the environment and Git configuration,
-        /// in the correct order or precedence.
-        /// </summary>
-        /// <param name="envarName">Optional environment variable name.</param>
-        /// <param name="section">Optional Git configuration section name.</param>
-        /// <param name="property">Git configuration property name. Required if <paramref name="section"/> is set, optional otherwise.</param>
-        /// <returns>All values for the specified setting, in order of precedence, or an empty collection if no such values are set.</returns>
-        public IEnumerable<string> GetSettingValues(string envarName, string section, string property)
-        {
-            string value;
-
-            if (envarName != null)
-            {
-                if (_environment.Variables.TryGetValue(envarName, out value))
-                {
-                    yield return value;
-                }
-            }
-
-            if (section != null && property != null)
-            {
-                IGitConfiguration config = GetGitConfiguration();
-
-                if (RemoteUri != null)
-                {
-                    /*
-                     * Look for URL scoped "section" configuration entries, starting from the most specific
-                     * down to the least specific (stopping before the TLD).
-                     *
-                     * In a divergence from standard Git configuration rules, we also consider matching URL scopes
-                     * without a scheme ("protocol://").
-                     *
-                     * For each level of scope, we look for an entry with the scheme included (the default), and then
-                     * also one without it specified. This allows you to have one configuration scope for both "http" and
-                     * "https" without needing to repeat yourself, for example.
-                     *
-                     * For example, starting with "https://foo.example.com/bar/buzz" we have:
-                     *
-                     *   1a. [section "https://foo.example.com/bar/buzz"]
-                     *          property = value
-                     *
-                     *   1b. [section "foo.example.com/bar/buzz"]
-                     *          property = value
-                     *
-                     *   2a. [section "https://foo.example.com/bar"]
-                     *          property = value
-                     *
-                     *   2b. [section "foo.example.com/bar"]
-                     *          property = value
-                     *
-                     *   3a. [section "https://foo.example.com"]
-                     *          property = value
-                     *
-                     *   3b. [section "foo.example.com"]
-                     *          property = value
-                     *
-                     *   4a. [section "https://example.com"]
-                     *          property = value
-                     *
-                     *   4b. [section "example.com"]
-                     *          property = value
-                     *
-                     */
-
-                    // Enumerate all configuration entries with the correct section and property name
-                    // and make a local copy of them here to avoid needing to call `TryGetValue` on the
-                    // IGitConfiguration object multiple times in a loop below.
-                    var configEntries = new Dictionary<string, string>();
-                    config.Enumerate((entryName, entryValue) =>
-                    {
-                        string entrySection = entryName.TruncateFromIndexOf('.');
-                        string entryProperty = entryName.TrimUntilLastIndexOf('.');
-
-                        if (StringComparer.OrdinalIgnoreCase.Equals(entrySection, section) &&
-                            StringComparer.OrdinalIgnoreCase.Equals(entryProperty, property))
-                        {
-                            configEntries[entryName] = entryValue;
-                        }
-
-                        // Continue the enumeration
-                        return true;
-                    });
-
-                    foreach (string scope in RemoteUri.GetGitConfigurationScopes())
-                    {
-                        string queryName = $"{section}.{scope}.{property}";
-                        // Look for a scoped entry that includes the scheme "protocol://example.com" first as this is more specific
-                        if (configEntries.TryGetValue(queryName, out value))
-                        {
-                            yield return value;
-                        }
-
-                        // Now look for a scoped entry that omits the scheme "example.com" second as this is less specific
-                        string scopeWithoutScheme = scope.TrimUntilIndexOf(Uri.SchemeDelimiter);
-                        string queryWithSchemeName = $"{section}.{scopeWithoutScheme}.{property}";
-                        if (configEntries.TryGetValue(queryWithSchemeName, out value))
-                        {
-                            yield return value;
-                        }
-                    }
-                }
-
-                /*
-                 * Try to look for an un-scoped "section" property setting:
-                 *
-                 *    [section]
-                 *        property = value
-                 *
-                 */
-                if (config.TryGetValue($"{section}.{property}", out value))
-                {
-                    yield return value;
-                }
-            }
-        }
-
         private IGitConfiguration GetGitConfiguration() => _gitConfig ?? (_gitConfig = _git.GetConfiguration(RepositoryPath));
 
         #region IDisposable

src/shared/TestInfrastructure/Objects/TestCommandContext.cs

@@ -10,17 +10,33 @@ namespace Microsoft.Git.CredentialManager.Tests.Objects
 {
     public class TestCommandContext : ICommandContext
     {
-        public TestSettings Settings { get; set; } = new TestSettings();
-        public TestStandardStreams Streams { get; set; } = new TestStandardStreams();
-        public TestTerminal Terminal { get; set; } = new TestTerminal();
-        public bool IsDesktopSession { get; set; } = true;
-        public ITrace Trace { get; set; } = new NullTrace();
-        public TestFileSystem FileSystem { get; set; } = new TestFileSystem();
-        public TestCredentialStore CredentialStore { get; set; } = new TestCredentialStore();
-        public TestHttpClientFactory HttpClientFactory { get; set; } = new TestHttpClientFactory();
-        public TestGit Git { get; set; } = new TestGit();
-        public TestEnvironment Environment { get; set; } = new TestEnvironment();
-        public TestSystemPrompts SystemPrompts { get; set; } = new TestSystemPrompts();
+        public TestCommandContext()
+        {
+            Streams = new TestStandardStreams();
+            Terminal = new TestTerminal();
+            IsDesktopSession = true;
+            Trace = new NullTrace();
+            FileSystem = new TestFileSystem();
+            CredentialStore = new TestCredentialStore();
+            HttpClientFactory = new TestHttpClientFactory();
+            Git = new TestGit();
+            Environment = new TestEnvironment();
+            SystemPrompts = new TestSystemPrompts();
+
+            Settings = new TestSettings {Environment = Environment, GitConfiguration = Git.GlobalConfiguration};
+        }
+
+        public TestSettings Settings { get; set; }
+        public TestStandardStreams Streams { get; set; }
+        public TestTerminal Terminal { get; set; }
+        public bool IsDesktopSession { get; set; }
+        public ITrace Trace { get; set; }
+        public TestFileSystem FileSystem { get; set; }
+        public TestCredentialStore CredentialStore { get; set; }
+        public TestHttpClientFactory HttpClientFactory { get; set; }
+        public TestGit Git { get; set; }
+        public TestEnvironment Environment { get; set; }
+        public TestSystemPrompts SystemPrompts { get; set; }
 
         #region ICommandContext