-
Notifications
You must be signed in to change notification settings - Fork 303
Extend git-plugin with --match Option #126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hi @ktoso, Thx :) |
97e085d
to
7ee11ec
Compare
hey, I'm back with some time to look into this. I want to release something tomorrow so I'll review and possibly merge (even if manual) :-) |
@@ -148,6 +148,8 @@ | |||
* since tag v1.2 that points at object deadbee....). | |||
* <p/> | |||
* <pre>false</pre> by default. | |||
* | |||
* @parameter default-value=false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
Merged! |
@@ -529,12 +532,16 @@ Optional parameters: | |||
* **dateFormat** - `(default: dd.MM.yyyy '@' HH:mm:ss z)` is a normal SimpleDateFormat String and will be used to represent git.build.time and git.commit.time | |||
* **verbose** - `(default: false)` if true the plugin will print a summary of all collected properties when it's done | |||
* **generateGitPropertiesFile** -`(default: false)` this is false by default, forces the plugin to generate the git.properties file | |||
* **generateGitPropertiesFilename** - `(default: src/main/resources/git.properties)` - The path for the to be generated properties file, it's relative to ${project.basedir} | |||
* **generateGitPropertiesFilename** - `(default: ${project.build.outputDirectory}/git.properties)` - The path for the to be generated properties file. The path can be relative to ${project.basedir} (e.g. target/classes/git.properties) or can be a full path (e.g. ${project.build.outputDirectory}/git.properties). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice, thanks!
Hi @ktoso ! Thanks for this great plugin :) |
Hi konrad,
it's me once again ;)
I extended the describe-option of the git-commit-id-plugin with the match-Option (@see: #97).
Any suggestions for improvements are welcome.
BTW: I updated the README a bit...change it if you don't like the description ;)