Skip to content

Conversation

TheSnoozer
Copy link
Collaborator

Hi konrad,
it's me once again ;)
I extended the describe-option of the git-commit-id-plugin with the match-Option (@see: #97).

Any suggestions for improvements are welcome.

BTW: I updated the README a bit...change it if you don't like the description ;)

@TheSnoozer
Copy link
Collaborator Author

Hi @ktoso,
can u review this pls?

Thx :)

@ktoso ktoso force-pushed the master branch 7 times, most recently from 97e085d to 7ee11ec Compare October 21, 2014 22:05
@ktoso
Copy link
Collaborator

ktoso commented Dec 7, 2014

hey, I'm back with some time to look into this. I want to release something tomorrow so I'll review and possibly merge (even if manual) :-)

@@ -148,6 +148,8 @@
* since tag v1.2 that points at object deadbee....).
* <p/>
* <pre>false</pre> by default.
*
* @parameter default-value=false
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@ktoso ktoso merged commit 60cb978 into git-commit-id:master Dec 7, 2014
@ktoso
Copy link
Collaborator

ktoso commented Dec 7, 2014

Merged!
Thanks a lot @TheSnoozer, and sorry for the delays.
Planned release time is tomorrow night CET :)

@@ -529,12 +532,16 @@ Optional parameters:
* **dateFormat** - `(default: dd.MM.yyyy '@' HH:mm:ss z)` is a normal SimpleDateFormat String and will be used to represent git.build.time and git.commit.time
* **verbose** - `(default: false)` if true the plugin will print a summary of all collected properties when it's done
* **generateGitPropertiesFile** -`(default: false)` this is false by default, forces the plugin to generate the git.properties file
* **generateGitPropertiesFilename** - `(default: src/main/resources/git.properties)` - The path for the to be generated properties file, it's relative to ${project.basedir}
* **generateGitPropertiesFilename** - `(default: ${project.build.outputDirectory}/git.properties)` - The path for the to be generated properties file. The path can be relative to ${project.basedir} (e.g. target/classes/git.properties) or can be a full path (e.g. ${project.build.outputDirectory}/git.properties).
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, thanks!

@TheSnoozer
Copy link
Collaborator Author

Hi @ktoso !
Thanks for reviewing.
And no worries about the delay ;)

Thanks for this great plugin :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants