Multi fix #106
Closed
Multi fix #106
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peso
force-pushed
the
multi-fix
branch
2 times, most recently
from
0ff99b9 to
9239b78
Compare
This function determines where branches connect.
By using Rust a little differently the amount of curtains can be reduced. This helps readability, but it also simplifies the following bug fixes.
Collaborator
|
@peso Sorry for the delay. I will only be able to review this in approx. 2 weeks. |
Collaborator
Author
|
Let me know if you prefer multiple PR. |
Collaborator
Author
|
I will submit the changes here as a number of smaller PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes issue #6, issue #12, and issue #67.
The work on documentation is not complete, but since that is a large task it is probably best to commit piece by piece. Also, by requesting a pull I hope to get some comments on my understanding of the algorithm.
The work is driven by the need for gitui to have a branching algorithm. There will probably be more changes requested, in particular on the API.