Skip to content

Allows None as a value in InvoiceResponse #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
XaviTorello merged 3 commits into from
Jun 20, 2018
Merged

Allows None as a value in InvoiceResponse #12

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
40926b6
Allow None in organoGestor in Response
gdalmau Jun 19, 2018
8044074
Merge pull request #11 from gisce/allow_none_in_organo_gestor
XaviTorello Jun 20, 2018
e488040
Update 0.2.7 info with organoGestor updates
XaviTorello Jun 20, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# 0.2.0
# 0.2
- New package `face.services` desired to handle and group SOAP available methods by each type:
- service -> generic SOAP service
- `Invoice`
Expand All @@ -16,6 +16,7 @@
- Models that use codes now validates it using the `face.codes` schema validators
- Added official documentation at `/docs`
- `email` where to reach notifications is now configurable thanks to @gdalmau (see #7)
- `InvoiceResponse.organoGestor` now allows `None` value (see #11)

# 0.1.0
- Initial FACe interface
Expand Down
4 changes: 2 additions & 2 deletions face/models/invoice.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ def create_tramitacion(self, data):
class InvoiceResponse(object):
def __init__(self, **kwargs):
self.numeroRegistro = kwargs.get('numeroRegistro', None)
self.organoGestor = kwargs.get('organoGestor')
self.organoGestor = kwargs.get('organoGestor', None)
self.unidadTramitadora = kwargs.get('unidadTramitadora', None)
self.oficinaContable = kwargs.get('oficinaContable', None)
self.identificadorEmisor = kwargs.get('identificadorEmisor', None)
Expand All @@ -60,7 +60,7 @@ def __getitem__(self, item):

class InvoiceResponseSchema(Schema):
numeroRegistro = fields.Integer(allow_none=True)
organoGestor = fields.String()
organoGestor = fields.String(allow_none=True)
unidadTramitadora = fields.String(allow_none=True)
oficinaContable = fields.String(allow_none=True)
identificadorEmisor = fields.String(allow_none=True)
Expand Down