Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Frontend web development react angular vue - Using Vue.js with CDN #628

Conversation

Safwan310
Copy link
Contributor


Description 📜

Added a file that explains how to use Vue.js with a CDN.
Fixes #523


Type of change 📝

  • Documentation (Content Creation in the form of codes or tutorials)

Domain of Contribution 📊

  • Frontend Dev (React, Angular, Vue)

Checklist ✅

  • I follow Contributing Guidelines & Code of conduct of this project.
  • I have performed a self-review of my own code or work.
  • I have commented my code, particularly in hard-to-understand areas.
  • My changes generates no new warnings.
  • I'm GWOC'21 contributor

Screenshots / Gif (Optional) 📸


@anandhu720 anandhu720 added this to the Frontend With Frameworks milestone Sep 18, 2021
@SourabhSaraswat-191939
Copy link
Contributor

Hi @Safwan310,
Looks good. But there are some corrections.

  1. Explain the code a bit which you mentioned as an example. So that it will be good for a learner to get an idea. How it is working.
  2. The image which you attached to show the output of the code is looking like a subtext of the upper heading. So, please change the image, you can attach an image in which this output is shown in the browser.

Copy link
Collaborator

@anandhu720 anandhu720 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some changes are required.Changes are mentioned by @SourabhSaraswat-191939 .
If you have any doubts contact @SourabhSaraswat-191939

Copy link
Collaborator

@anandhu720 anandhu720 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image link is not attached correctly.
![ ](./assets/cdnoutput.png) is correct I think
Please cross check it

@Safwan310
Copy link
Contributor Author

image link is not attached correctly.
![ ](./assets/cdnoutput.png) is correct I think
Please cross check it

But it works.... Anyway I will edit this line

Copy link
Collaborator

@anandhu720 anandhu720 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work, need one more review from @SourabhSaraswat-191939 after that we can merge

@SourabhSaraswat-191939
Copy link
Contributor

Good work, need one more review from @SourabhSaraswat-191939 after that we can merge

LGTM 👍🏻
We can merge it.

@anandhu720 anandhu720 merged commit be10f46 into girlscript:Frontend_Web_Development_React_Angular_Vue Sep 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FRONTEND WITH FRAMEWORK: VueJS-1.2 => Introduction to VueJS using CDN
4 participants