Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions Directory.Build.targets
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
<Project>
<PropertyGroup>
<FSharpAnalyzersOtherFlags>--analyzers-path &quot;$(PkgG-Research_FSharp_Analyzers)&quot;</FSharpAnalyzersOtherFlags>
<FSharpAnalyzersOtherFlags>$(FSharpAnalyzersOtherFlags) --analyzers-path &quot;$(PkgIonide_Analyzers)&quot;</FSharpAnalyzersOtherFlags>
<FSharpAnalyzersOtherFlags>--analyzers-path "$(PkgG-Research_FSharp_Analyzers)"</FSharpAnalyzersOtherFlags>
<FSharpAnalyzersOtherFlags>$(FSharpAnalyzersOtherFlags) --analyzers-path "$(PkgIonide_Analyzers)"</FSharpAnalyzersOtherFlags>
<FSharpAnalyzersOtherFlags>$(FSharpAnalyzersOtherFlags) --configuration $(Configuration)</FSharpAnalyzersOtherFlags>
<FSharpAnalyzersOtherFlags>$(FSharpAnalyzersOtherFlags) --exclude-analyzers PartialAppAnalyzer</FSharpAnalyzersOtherFlags>
<FSharpAnalyzersOtherFlags>$(FSharpAnalyzersOtherFlags) --report &quot;analysis.sarif&quot;</FSharpAnalyzersOtherFlags>
<FSharpAnalyzersOtherFlags>$(FSharpAnalyzersOtherFlags) --report "analysis.sarif"</FSharpAnalyzersOtherFlags>
</PropertyGroup>
</Project>
10 changes: 5 additions & 5 deletions src/Giraffe/Giraffe.fsproj
Original file line number Diff line number Diff line change
Expand Up @@ -39,9 +39,9 @@
</PropertyGroup>

<ItemGroup>
<None Include="$(MSBuildThisFileDirectory)../../giraffe-64x64.png" Pack="true" PackagePath="$(PackageIconUrl)"/>
<None Include="$(MSBuildThisFileDirectory)../../README.md" Pack="true" PackagePath="/"/>
<None Include="$(MSBuildThisFileDirectory)../../LICENSE" Pack="true" PackagePath="/"/>
<None Include="$(MSBuildThisFileDirectory)../../giraffe-64x64.png" Pack="true" PackagePath="$(PackageIconUrl)" />
<None Include="$(MSBuildThisFileDirectory)../../README.md" Pack="true" PackagePath="/" />
<None Include="$(MSBuildThisFileDirectory)../../LICENSE" Pack="true" PackagePath="/" />

</ItemGroup>

Expand All @@ -66,8 +66,8 @@

<PackageReference Include="FSharp.Core" Version="6.0.0" />
<PackageReference Include="Microsoft.IO.RecyclableMemoryStream" Version="3.0.*" />
<PackageReference Include="System.Text.Json" Version="8.0.*" />
<PackageReference Include="FSharp.SystemTextJson" Version="1.3.*" />
<PackageReference Include="System.Text.Json" Version="9.0.7" />
Copy link

Copilot AI Jul 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updating System.Text.Json from 8.0.* to 9.0.7 represents a major version change that could introduce breaking changes. Consider verifying that all existing JSON serialization behavior remains compatible, especially around null handling, property naming policies, and custom converters.

Suggested change
<PackageReference Include="System.Text.Json" Version="9.0.7" />
<PackageReference Include="System.Text.Json" Version="8.0.*" />

Copilot uses AI. Check for mistakes.
<PackageReference Include="FSharp.SystemTextJson" Version="1.4.36" />
Copy link

Copilot AI Jul 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The FSharp.SystemTextJson update from 1.3.* to 1.4.36 should be tested for compatibility with the new System.Text.Json 9.0.7. Major version updates in both packages simultaneously could compound potential breaking changes in F# record and union type serialization.

Suggested change
<PackageReference Include="FSharp.SystemTextJson" Version="1.4.36" />
<PackageReference Include="FSharp.SystemTextJson" Version="1.3.*" />

Copilot uses AI. Check for mistakes.
<PackageReference Include="Microsoft.SourceLink.GitHub" Version="8.0.*" PrivateAssets="All" />
<PackageReference Include="Giraffe.ViewEngine" Version="1.4.*" />
</ItemGroup>
Expand Down
4 changes: 2 additions & 2 deletions tests/Giraffe.Tests/Giraffe.Tests.fsproj
Original file line number Diff line number Diff line change
Expand Up @@ -44,9 +44,9 @@
</ItemGroup>

<ItemGroup>
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.12.*" />
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.14.1" />
<PackageReference Include="xunit" Version="2.9.*" />
<PackageReference Include="xunit.runner.visualstudio" Version="3.0.*">
<PackageReference Include="xunit.runner.visualstudio" Version="3.1.3">
<PrivateAssets>all</PrivateAssets>
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
</PackageReference>
Expand Down
Loading