Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Follow-up from "Minor code optimisation #567" #577

Open
64J0 opened this issue Feb 23, 2024 · 0 comments
Open

Follow-up from "Minor code optimisation #567" #577

64J0 opened this issue Feb 23, 2024 · 0 comments
Labels
help wanted Community contribution or any kind of help much appreciated

Comments

@64J0
Copy link
Member

64J0 commented Feb 23, 2024 •
edited
Loading

Description:

@Thorium suggested:

Another modification to consider, would be adding [<Struct>] attribute to Giraffe's minor enum-types like HttpVerb, MatchMode, Precondition, CacheDirective and RangeBoundary. But if there are proper performance tests somewhere, could be first tested if they'd have any effect or not. But I guess that goes around questions like should some Option values changed to ValueOption values.

Reference to the PR: #567
@64J0 64J0 added the help wanted Community contribution or any kind of help much appreciated label Feb 23, 2024
1eyewonder added a commit to 1eyewonder/Giraffe that referenced this issue Jul 14, 2024
@1eyewonder
Added fsharp analyzers in response to seeing Follow-up from "Minor co…
abc1b24 
…de optimisation giraffe-fsharp#567" giraffe-fsharp#577
@1eyewonder 1eyewonder mentioned this issue Jul 15, 2024
Merged
64J0 pushed a commit to 1eyewonder/Giraffe that referenced this issue Jul 21, 2024
@1eyewonder @64J0
Added fsharp analyzers in response to seeing Follow-up from "Minor co…
f96e0df 
…de optimisation giraffe-fsharp#567" giraffe-fsharp#577
64J0 pushed a commit to 1eyewonder/Giraffe that referenced this issue Jul 25, 2024
@1eyewonder @64J0
Added fsharp analyzers in response to seeing Follow-up from "Minor co…
796df5e 
…de optimisation giraffe-fsharp#567" giraffe-fsharp#577
64J0 added a commit that referenced this issue Jul 25, 2024
@1eyewonder @64J0
Add F# Analyzers (#603)
5385767 
* Added fsharp analyzers in response to seeing Follow-up from "Minor code optimisation #567" #577

* Moved packages to proj file instead of props file

* add analyzers CI workflow and define the report name at Directory.Build.Targets

---------

Co-authored-by: 64J0 <vinigaio97@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Community contribution or any kind of help much appreciated
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@64J0