Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I4trust/conformance tests #344

Merged
merged 15 commits into from
Sep 6, 2023

Conversation

fdelavega
Copy link
Contributor

Proposed changes

This PR updates the implementation of the IShare protocol to make it fully compliant with the specification after running the tests available in iShare conformance tool

Types of changes

What types of changes does your code introduce to the project: Put an x in
the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality
    to not work as expected)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating
the PR. If you're unsure about any of them, don't hesitate to ask. We're here to
help! This is simply a reminder of what we are going to look for before merging
your code.

  • I have read the
    CONTRIBUTING
    doc
  • I have signed the
    CLA
  • I have added tests that prove my fix is effective or that my feature
    works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream
    modules

Further comments

If this is a relatively large or complex change, kick off the discussion by
explaining why you chose the solution you did and what alternatives you
considered, etc...

@github-actions
Copy link
Contributor

github-actions bot commented Aug 29, 2023

CLA Assistant Lite bot All contributors have signed the CLA ✍️

@fdelavega
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@aafrecct
Copy link
Contributor

I have read the CLA Document and I hereby sign the CLA

github-actions bot added a commit that referenced this pull request Aug 29, 2023
@apozohue10 apozohue10 merged commit 4e3c786 into ging:master Sep 6, 2023
5 of 8 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Sep 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants