fix: suppress http.ErrAbortHandler in recover #4336
+28
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves an issue where
http.ErrAbortHandler
panics are incorrectly logged as errors by thegin.Recovery
middleware.The current
gin.Recovery
middleware only handles "broken pipe" errors, causing it to log unnecessary stack traces when a client prematurely closes a connection. This behavior is misleading, ashttp.ErrAbortHandler
is intentionally used byhttputil.ReverseProxy
to abort requests and is not a true application error.This change modifies the
Recovery
middleware to explicitly check forhttp.ErrAbortHandler
and suppress the logging of stack traces for this specific panic. This aligns the middleware with the intended behavior of the Go standard library and improves log clarity by filtering out expected panics.Related Issue
References
http.ErrAbortHandler
.Similar PRs