Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(engine): fix comments for the With #3955

Merged
merged 1 commit into from
May 7, 2024

Conversation

flc1125
Copy link
Contributor

@flc1125 flc1125 commented May 7, 2024

Solved: #3572 (review)

Signed-off-by: Flc゛ <four_leaf_clover@foxmail.com>
@flc1125 flc1125 changed the title fix(gin): fix comments for the With fix(engine): fix comments for the With May 7, 2024
Copy link

codecov bot commented May 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.18%. Comparing base (3dc1cd6) to head (eb18db7).
Report is 43 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3955      +/-   ##
==========================================
- Coverage   99.21%   99.18%   -0.03%     
==========================================
  Files          42       43       +1     
  Lines        3182     2716     -466     
==========================================
- Hits         3157     2694     -463     
+ Misses         17       12       -5     
- Partials        8       10       +2     
Flag Coverage Δ
?
-tags "sonic avx" 99.18% <ø> (?)
-tags go_json 99.18% <ø> (?)
-tags nomsgpack 99.17% <ø> (?)
go-1.18 99.11% <ø> (-0.01%) ⬇️
go-1.19 99.18% <ø> (-0.03%) ⬇️
go-1.20 99.18% <ø> (-0.03%) ⬇️
go-1.21 99.18% <ø> (-0.03%) ⬇️
go-1.22 99.18% <ø> (?)
macos-latest 99.18% <ø> (-0.03%) ⬇️
ubuntu-latest 99.18% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@appleboy appleboy changed the title fix(engine): fix comments for the With docs(engine): fix comments for the With May 7, 2024
@appleboy appleboy added this to the v1.11 milestone May 7, 2024
@appleboy appleboy merged commit e60113d into gin-gonic:master May 7, 2024
54 of 55 checks passed
@flc1125 flc1125 deleted the fix-comments branch May 7, 2024 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants