Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(testing): add go1.22 version #3842

Merged
merged 3 commits into from
Feb 18, 2024
Merged

ci(testing): add go1.22 version #3842

merged 3 commits into from
Feb 18, 2024

Conversation

appleboy
Copy link
Member

  • Update the version of gin to v1.56.1 in the .github/workflows/gin.yml file
  • Add go version 1.22 to the list of supported versions in the .github/workflows/gin.yml file

…flows

- Update the version of gin to v1.56.1 in the `.github/workflows/gin.yml` file
- Add go version 1.22 to the list of supported versions in the `.github/workflows/gin.yml` file
- Remove the unnecessary step "Set up Go" in the `.github/workflows/goreleaser.yml` file
- Update the step name "Run GoReleaser" in the `.github/workflows/goreleaser.yml` file

Signed-off-by: appleboy <appleboy.tw@gmail.com>
@appleboy appleboy added this to the v1.10 milestone Feb 12, 2024
Copy link

codecov bot commented Feb 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3dc1cd6) 99.21% compared to head (05c8205) 99.36%.
Report is 4 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3842      +/-   ##
==========================================
+ Coverage   99.21%   99.36%   +0.15%     
==========================================
  Files          42       43       +1     
  Lines        3182     2676     -506     
==========================================
- Hits         3157     2659     -498     
+ Misses         17        9       -8     
  Partials        8        8              
Flag Coverage Δ
?
-race ∅ <ø> (?)
-tags "sonic avx" 99.35% <ø> (?)
-tags go_json 99.35% <ø> (?)
-tags nomsgpack 99.35% <ø> (?)
go-1.18 99.28% <ø> (+0.16%) ⬆️
go-1.19 99.36% <ø> (+0.15%) ⬆️
go-1.20 99.36% <ø> (+0.15%) ⬆️
go-1.21 99.36% <ø> (+0.15%) ⬆️
go-1.22 99.36% <ø> (?)
macos-latest 99.36% <ø> (+0.15%) ⬆️
ubuntu-latest 99.36% <ø> (+0.15%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@appleboy appleboy requested a review from thinkerou February 12, 2024 08:13
@the-eduardo
Copy link

On gin.yml line 77 it mentions go-version == '1.21.x', shouldn't that also be changed to 1.22.x?

if: matrix.go-version == '1.21.x'

- Update conditional Go version check in GitHub Actions workflow from `1.21.x` to `1.22.x`

Signed-off-by: Bo-Yi Wu <appleboy.tw@gmail.com>
@appleboy
Copy link
Member Author

@the-eduardo Fixed in 59fc7c7

@appleboy
Copy link
Member Author

@thinkerou Please help to review.

- Add `-race` flag to the test-tags list in GitHub Actions workflow configuration

Signed-off-by: Bo-Yi Wu <appleboy.tw@gmail.com>
@thinkerou thinkerou merged commit 000fdb3 into gin-gonic:master Feb 18, 2024
55 checks passed
@appleboy appleboy deleted the go1.22 branch February 18, 2024 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants