Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(route): Add fullPath in context copy #3784

Merged
merged 3 commits into from
Mar 6, 2024

Conversation

KarthikReddyPuli
Copy link
Contributor

Summary

When a gin.Context was copied using the Copy method, fullPath was not getting copied to the new context. This PR fixes it by copying the fullPath to the new context

@appleboy appleboy added this to the v1.10 milestone Dec 6, 2023
Copy link

codecov bot commented Dec 6, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.36%. Comparing base (3dc1cd6) to head (3166ecd).
Report is 10 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3784      +/-   ##
==========================================
+ Coverage   99.21%   99.36%   +0.15%     
==========================================
  Files          42       43       +1     
  Lines        3182     2677     -505     
==========================================
- Hits         3157     2660     -497     
+ Misses         17        9       -8     
  Partials        8        8              
Flag Coverage Δ
?
-race ∅ <ø> (?)
-tags "sonic avx" 99.35% <100.00%> (?)
-tags go_json 99.35% <100.00%> (?)
-tags nomsgpack 99.35% <100.00%> (?)
go-1.18 99.29% <100.00%> (+0.17%) ⬆️
go-1.19 99.36% <100.00%> (+0.15%) ⬆️
go-1.20 99.36% <100.00%> (+0.15%) ⬆️
go-1.21 99.36% <100.00%> (+0.15%) ⬆️
go-1.22 99.36% <100.00%> (?)
macos-latest 99.36% <100.00%> (+0.15%) ⬆️
ubuntu-latest 99.36% <100.00%> (+0.15%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@KarthikReddyPuli
Copy link
Contributor Author

@appleboy can you please review and merge this PR ?

@appleboy
Copy link
Member

appleboy commented Mar 5, 2024

@KarthikReddyPuli Please help to fix conflcts.

@appleboy appleboy changed the title fix: Add fullPath in context copy fix(route): Add fullPath in context copy Mar 5, 2024
@appleboy appleboy merged commit 09f8224 into gin-gonic:master Mar 6, 2024
55 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants