Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(route): add Engine.PathFor function #3589

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 24 additions & 0 deletions docs/doc.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
- [Using GET, POST, PUT, PATCH, DELETE and OPTIONS](#using-get-post-put-patch-delete-and-options)
- [Parameters in path](#parameters-in-path)
- [Querystring parameters](#querystring-parameters)
- [Retrieving the path of a registered handler](#retrieving-the-path-of-a-registered-handler)
- [Multipart/Urlencoded Form](#multiparturlencoded-form)
- [Another example: query + post form](#another-example-query--post-form)
- [Map as querystring or postform parameters](#map-as-querystring-or-postform-parameters)
Expand Down Expand Up @@ -180,6 +181,29 @@ func main() {
}
```

### Retrieving the path of a registered handler

Once a handler is registered with the router, you can retrieve its path with the `PathFor` method:

```go
func main() {
// Creates a gin router with default middleware:
// logger and recovery (crash-free) middleware
router := gin.Default()

getUser := func(c *Context) {
// Handle the GET request.
}
router.GET("/users/:name", getUser)
path := router.PathFor(getUser, ":name", "gopher")

print(path) // Prints /users/gopher

router.Run()
}
router := gin.Default()
```

### Multipart/Urlencoded Form

```go
Expand Down
66 changes: 66 additions & 0 deletions gin.go
Original file line number Diff line number Diff line change
Expand Up @@ -353,6 +353,24 @@ func (engine *Engine) Routes() (routes RoutesInfo) {
return routes
}

// Routes returns a slice of registered routes, including some useful information, such as:
// the http method, path and the handler name.
func (engine *Engine) Route(handler HandlerFunc) (route RouteInfo, ok bool) {
handlerName := nameOfFunction(handler)
routes := RoutesInfo{}
for _, tree := range engine.trees {
routes = iterate("", tree.method, routes, tree.root)

for _, route := range routes {
if route.Handler == handlerName {
return route, true
}
}
}

return RouteInfo{}, false
}

func iterate(path, method string, routes RoutesInfo, root *node) RoutesInfo {
path += root.path
if len(root.handlers) > 0 {
Expand Down Expand Up @@ -589,6 +607,43 @@ func (engine *Engine) HandleContext(c *Context) {
c.index = oldIndexValue
}

// PathFor returns the path registered for the specified handler function.
// Route values are passed pair-wise as key value.
func (engine *Engine) PathFor(handler HandlerFunc, values ...interface{}) string {
route, ok := engine.Route(handler)

if !ok || len(route.Path) == 0 || len(values)%2 != 0 {
return ""
}

url := route.Path
params := make(map[string]string)
if len(values) > 0 {
key := ""
for k, v := range values {
if k%2 == 0 {
key = fmt.Sprint(v)
} else {
params[key] = fmt.Sprint(v)
}
}
}
urls := strings.Split(url, "/")
for _, v := range urls {
if v == "" {
continue
}
if v[0:1] == ":" {
if u, ok := params[v]; ok {
delete(params, v)
url = strings.Replace(url, v, u, 1)
}
}
}

return url + toQuerystring(params)
}

func (engine *Engine) handleHTTPRequest(c *Context) {
httpMethod := c.Request.Method
rPath := c.Request.URL.Path
Expand Down Expand Up @@ -709,3 +764,14 @@ func redirectRequest(c *Context) {
http.Redirect(c.Writer, req, rURL, code)
c.writermem.WriteHeaderNow()
}

func toQuerystring(params map[string]string) string {
if len(params) == 0 {
return ""
}
u := "?"
for k, v := range params {
u += k + "=" + v + "&"
}
return strings.TrimRight(u, "&")
}
19 changes: 19 additions & 0 deletions gin_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -676,6 +676,25 @@ func TestPrepareTrustedCIRDsWith(t *testing.T) {
}
}

func TestPathFor(t *testing.T) {
r := New()

getIndex := func(c *Context) {}
r.GET("/", getIndex)

users := r.Group("/users")

postUser := func(c *Context) {}
users.POST("", postUser)

getUser := func(c *Context) {}
users.GET("/:name", getUser)

assert.Equal(t, "/", r.PathFor(getIndex))
assert.Equal(t, "/users", r.PathFor(postUser))
assert.Equal(t, "/users/gopher", r.PathFor(getUser, ":name", "gopher"))
}

func parseCIDR(cidr string) *net.IPNet {
_, parsedCIDR, err := net.ParseCIDR(cidr)
if err != nil {
Expand Down