Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The utility of the
c.JSON
helper or othercontext.Render
methods not returning an error simplifies client code.There are rare errors during rendering that result in a panic, which most production systems will handle in middleware.
This introduces the ability to detect that it is a gin rendering error in the panic handler as opposed to other handler logic panics.
To be able to trap c.JSON render panics this PR will also need #3390 - which changes the JSON renderer to be more consistent, until that is also merged this context Render panic will not fire.
master