Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(route): redirectSlash bug #3227

Merged
merged 2 commits into from
Nov 6, 2022
Merged

fix(route): redirectSlash bug #3227

merged 2 commits into from
Nov 6, 2022

Conversation

thinkerou
Copy link
Member

@thinkerou thinkerou commented Jul 3, 2022 •
edited
Loading

fixes #2959
fixes #2282
fixes #2211

code from julienschmidt/httprouter#342

@thinkerou thinkerou added this to the v1.9 milestone Jul 3, 2022
@codecov
Copy link

codecov bot commented Jul 3, 2022 •
edited
Loading

Codecov Report

Merging #3227 (3b8c932) into master (12b55b4) will increase coverage by 0.16%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #3227      +/-   ##
==========================================
+ Coverage   98.22%   98.38%   +0.16%     
==========================================
  Files          43       43              
  Lines        3148     3153       +5     
==========================================
+ Hits         3092     3102      +10     
+ Misses         44       38       -6     
- Partials       12       13       +1
Flag Coverage Δ
go-1.14 ?
go-1.15 98.38% <100.00%> (+0.32%) ⬆️
go-1.16 98.35% <100.00%> (+0.32%) ⬆️
go-1.17 98.28% <100.00%> (+0.32%) ⬆️
go-1.18 98.28% <100.00%> (+0.32%) ⬆️
macos-latest 98.38% <100.00%> (+0.16%) ⬆️
nomsgpack 98.35% <100.00%> (+0.16%) ⬆️
ubuntu-latest 98.38% <100.00%> (+0.16%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
tree.go 100.00% <100.00%> (ø)
debug.go 91.66% <0.00%> (-8.34%) ⬇️
context.go 98.46% <0.00%> (+1.70%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 12b55b4...3b8c932. Read the comment docs.

@thinkerou
Copy link
Member Author

please review @appleboy thanks!

@delameter
Copy link

hope this will be merged soon, our team is having difficulties in a production environment because of this bug

@appleboy appleboy changed the title Fix redirectSlash bug fix(route): redirectSlash bug Nov 6, 2022
@appleboy appleboy merged commit 8b9c55e into gin-gonic:master Nov 6, 2022
@appleboy
Copy link
Member

appleboy commented Nov 6, 2022

@thinkerou maybe create a new tag for a bug fix?

@dkoszkul
Copy link

dkoszkul commented Nov 8, 2022

@thinkerou, @appleboy our team is also waiting for this fix. Creating new version would be very helpful. Thanks

@thinkerou
Copy link
Member Author

@thinkerou maybe create a new tag for a bug fix?

yes 👍

@dhawton
Copy link

dhawton commented Nov 21, 2022

Also waiting on this.

@appleboy appleboy modified the milestones: v1.9, v1.8.2 Nov 23, 2022
@appleboy
Copy link
Member

we will release the feature in v1.8.2

@appleboy
Copy link
Member

@thinkerou See the milestone: https://github.com/gin-gonic/gin/milestone/23

@appleboy
Copy link
Member

https://github.com/gin-gonic/gin/releases/tag/v1.8.2

thxCode pushed a commit to seal-io/gin that referenced this pull request Feb 6, 2023
@thinkerou @appleboy
fix(route): redirectSlash bug (gin-gonic#3227)
e305e21 
fixes gin-gonic#2959
fixes gin-gonic#2282
fixes gin-gonic#2211
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@meshenka meshenka meshenka approved these changes

@appleboy appleboy appleboy approved these changes

@javierprovecho javierprovecho Awaiting requested review from javierprovecho

Assignees
No one assigned
Labels
bug enhancement
Projects
None yet
Milestone
v1.8.2
6 participants
@thinkerou @delameter @appleboy @dkoszkul @dhawton @meshenka