feat: remove route in router #3145
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daheige
previously approved these changes
May 16, 2022
|
@appleboy please review this pr. thanks . |
appleboy
reviewed
Jun 24, 2022
| } | ||
|
|
||
| } | ||
|
|
||
| // Routes returns a slice of registered routes, including some useful information, such as: |
There was a problem hiding this comment.
what do you mean? do I need to create "task" for each TODO ？
|
maybe we should separate one gin-contrib, |
finish TODO
|
@appleboy finish TODO 。 @thinkerou It is all middleware in gin-contrib. you think the "REMOVE" function should be there? |
finish TODO
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feature： 'remove' is complex feature . This submit only gives the basic framework, and relevant details need to be improved later, such as modifying the priority of nodes
test：already make the basic test
ps：
this is my first time to submit PR to gin，I have great passion to make contribute。please tell if I did not go the right way